Sync with upstream @ 0599d07b #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task asks to multiply numeric object 'properties', however the term 'object properties' include both the 'property keys' of the object as well as the 'property values' of the object. It is clear the intention of the task is to change property values. This change improves clarity of the task description.
The current link is redirected to the parent chapter. This fix is in sync with https://javascript.info/operators#bitwise-operators and #2117
Currently, syntax of the 1 and 3 cases is the same.
Fix syntax enumeration in 1.4.7
minor change
1.4.1.8_multiply numeric - Update 'properties' to 'property values'
correct minor typo
Fix wrong variables names.
Fix link in 1.2.18
Update README.md
As promised.
1. Without a real sorting part, the data output is not the same as with real sort (as the array is not really sorted when the callback returns `undefined`). 2. Current example may somehow encourage a reader to write sorting callbacks with undetermined behavior.
As of the last versions of V8 (i.e. Chrome and Node.js), the current info seems outdated. See also https://v8.dev/blog/array-sort
The page of the current link has not this anchor anymore.
Proposed solution is in sync with some previous sort function examples. It also makes sorting stable (does not skip `0` result).
Fix link in 1.5.3
Make a solution of 1.5.5 task more correct
Fix a typo in a 1.5.5 task solution
Mention arr.flat()/arr.flatMap() in 1.5.5
Add a note on some()/every() short circuit
Fix some possible typos and omissions in 1.5.5
Correct outdated info
Fix typos in 1.5.3
Make code example more realistic and safe
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at 0599d07
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterPlease ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).
This PR will be closed and replaced with a new one in a few days.