Skip to content

Sync with upstream @ a0266c57 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 834 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
834 commits
Select commit Hold shift + click to select a range
d67929c
Updated article.md (better sentence flow)
Apr 21, 2019
b38d426
minor
iliakan Apr 21, 2019
b91abf8
minor
iliakan Apr 21, 2019
74e6955
Merge pull request #932 from cmdlhz/cmdlhz-patch-1
iliakan Apr 21, 2019
7aa1e0f
Corrected grammar
alaabouayed Apr 21, 2019
14163bb
Grammar
alaabouayed Apr 21, 2019
3b3363e
Merge pull request #934 from alaabouayed/patch-2
iliakan Apr 22, 2019
585b77d
Merge pull request #933 from alaabouayed/patch-3
iliakan Apr 22, 2019
203b8f9
fixes
iliakan Apr 22, 2019
3b14ed8
minor
iliakan Apr 22, 2019
8ef9fd2
Clarity
alaabouayed Apr 22, 2019
c5ce557
Fix name of JavaScript
lex111 Apr 23, 2019
6f55ba6
Merge pull request #936 from lex111/js-correct
iliakan Apr 23, 2019
10f84e7
6-data-storage/01-cookie: fix typo
lex111 Apr 23, 2019
b9ca311
Merge pull request #935 from alaabouayed/patch-4
iliakan Apr 23, 2019
735880d
Replace `Node.JS` with `Node.js`
lex111 Apr 23, 2019
4c2ab73
Replace `Github` with `GitHub`
lex111 Apr 23, 2019
190f0de
Corrected grammar
Violet-Bora-Lee Apr 25, 2019
743a0dc
Fix typo
h-n-y Apr 25, 2019
340c147
Merge pull request #939 from Violet-Bora-Lee/patch-1
iliakan Apr 25, 2019
8735adc
Merge pull request #940 from h-n-y/h-n-y-patch-1
iliakan Apr 25, 2019
273e47b
cleanup
iliakan Apr 25, 2019
b7b073b
Update article.md
marksq Apr 25, 2019
b2f8974
up
iliakan Apr 25, 2019
3465665
minor
iliakan Apr 25, 2019
e30d9d4
minor
iliakan Apr 25, 2019
9f06601
minor
iliakan Apr 25, 2019
65c5793
#8: fix unordered list
Antiai Apr 25, 2019
a9ee52b
#8: fix unordered list (#942)
lex111 Apr 25, 2019
f74963a
js/first-steps/function-basics: fix name of Lodash
lex111 Apr 25, 2019
04487f8
Update article.md
david-cho-lerat-HL2 Apr 26, 2019
3b20808
Update article.md
david-cho-lerat-HL2 Apr 26, 2019
076a624
Merge pull request #941 from marksq/patch-1
iliakan Apr 26, 2019
f652b9d
Merge pull request #944 from david-cho-lerat-HL2/patch-2
iliakan Apr 26, 2019
298e894
Merge pull request #943 from david-cho-lerat-HL2/patch-1
iliakan Apr 26, 2019
19223ae
minor
iliakan Apr 26, 2019
e9e3833
array-methods: wording
lex111 Apr 27, 2019
e41783a
regexp-character-classes: wording
lex111 Apr 27, 2019
10decb5
Fix typo
Apr 27, 2019
b10274c
Fix typo (#947)
lex111 Apr 27, 2019
5010620
Update article.md
Okoyecb Apr 27, 2019
f2328f0
Fix typo: authomatically
lex111 Apr 28, 2019
ad8a717
Array methods: minor mistake
shchegol Apr 29, 2019
6b9515f
minor
iliakan Apr 30, 2019
ae87b1a
Fix typo dynamicaly to dinamically
Apr 30, 2019
c0d068d
Fix typo dynamicaly to dinamically (#951)
lex111 Apr 30, 2019
2802a6d
replace "press" with "click"
pimonenkov Apr 30, 2019
aaab1d4
Update article.md
afeldspar Apr 30, 2019
593e122
fix
iliakan Apr 30, 2019
f8ef37f
21-regexp-unicode-properties: fix title
lex111 Apr 30, 2019
00654e3
Merge pull request #953 from afeldspar/patch-1
iliakan Apr 30, 2019
aa67109
Merge pull request #952 from pimonenkov/patch-2
iliakan Apr 30, 2019
7d23fd8
Merge pull request #949 from shchegol/master
iliakan Apr 30, 2019
0af081d
Merge pull request #948 from Okoyecb/patch-1
iliakan Apr 30, 2019
5e82fe2
Merge pull request #946 from javascript-tutorial/lex111-patch-2
iliakan Apr 30, 2019
19196e3
Merge pull request #945 from javascript-tutorial/lex111-patch-1
iliakan Apr 30, 2019
6a5f14d
6-data-storage/02-localstorage: fix highlight
lex111 May 1, 2019
ca92aed
1-js/12-generators-iterators/2-async-iterators-generators: fix typo
lex111 May 1, 2019
feebafc
Fix typos
lex111 May 1, 2019
b457de1
Replace error string with template strings
rezyx May 1, 2019
ac39b06
Merge pull request #956 from rezyx/replace-strings-11/async/02-promis…
iliakan May 2, 2019
be9dbd7
Fixed typos in defer example
yuenm18 May 3, 2019
042ebed
Fixed typos in defer example (#958)
lex111 May 3, 2019
9405358
1-js/06-advanced-functions/10-bind: fix markup
lex111 May 3, 2019
5982afb
Fix GitHub casing
rezyx May 4, 2019
5e37dbd
Fix GitHub casing (#959)
lex111 May 4, 2019
047ffa2
Update article.md
iliakan May 4, 2019
1764ee3
Fixed a small typo
luc4leone May 4, 2019
1646a74
Merge pull request #960 from luc4leone/patch-1
iliakan May 4, 2019
05f4502
fixes
iliakan May 4, 2019
1ba420f
fixes
iliakan May 4, 2019
1e99f7d
fixes
iliakan May 5, 2019
2634131
minor
iliakan May 5, 2019
6e77e3a
improvements
iliakan May 5, 2019
3623a88
up
iliakan May 6, 2019
db4d0de
fixes
iliakan May 6, 2019
702362f
8-web-components/3-shadow-dom: fix typos
lex111 May 6, 2019
ed86221
fixes
iliakan May 6, 2019
de5059f
Fix GitHub casing (04-promise-error-handling/article.md
rezyx May 6, 2019
9e598e5
Regex: moved and deleted content from the "Patterns and flags".
luc4leone May 6, 2019
40074e0
Merge pull request #964 from rezyx/fix-github-casing
lex111 May 6, 2019
dd6a630
Update solution.md
quangnd May 7, 2019
b7d7007
minor
iliakan May 7, 2019
f7a97ec
Merge pull request #965 from luc4leone/regex-intro
iliakan May 7, 2019
42f1dba
Merge pull request #967 from quangnd/patch-1
iliakan May 7, 2019
83b40bc
minor
iliakan May 7, 2019
0e5f889
fixed typo
Zyranivia May 8, 2019
c17491f
Update article.md
deniolp May 8, 2019
c8ed6f1
Added missing punctuation.
Zyranivia May 8, 2019
eabfc56
fixed typo (#968)
lex111 May 8, 2019
d15186d
fix
iliakan May 9, 2019
1a13331
Merge pull request #970 from Zyranivia/patch-2
iliakan May 9, 2019
7f5008e
Merge pull request #969 from deniolp/deniolp-patch-1
iliakan May 9, 2019
5f9597d
fix
iliakan May 9, 2019
11b1671
fixes
iliakan May 9, 2019
2addc4c
Fix typo
sparkofreason May 9, 2019
b9714f1
fix
iliakan May 9, 2019
07e09f8
Update article.md
alienfernandez May 9, 2019
2035e46
minor
iliakan May 9, 2019
4dc4272
minor
iliakan May 9, 2019
8e251ab
explanations
iliakan May 10, 2019
06f9927
remove extra article
iliakan May 10, 2019
0c2ef14
Update article.md (localstorage)
gongzemin May 10, 2019
00a01ec
Update LocalStorage
gongzemin May 10, 2019
637e8c1
Update article.md (LocalStorage) (#975)
lex111 May 10, 2019
e3c0be4
Fix typo (#971)
lex111 May 10, 2019
668bdf7
Update article.md (#972)
lex111 May 10, 2019
2b44781
fixes
iliakan May 11, 2019
f8f3c94
fix
iliakan May 11, 2019
f8570ae
fixes
iliakan May 11, 2019
29a3c58
fixes
iliakan May 11, 2019
9be9616
license
iliakan May 11, 2019
8b9aaa7
minor
iliakan May 11, 2019
5f423c8
minor
iliakan May 11, 2019
fd43d91
minor
iliakan May 11, 2019
b45c5a3
Fix typos
lex111 May 12, 2019
e6ed86c
Update article.md
gartenfeld May 13, 2019
dd67ddd
Merge pull request #978 from gartenfeld/patch-1
iliakan May 13, 2019
bc7d43c
minor
iliakan May 13, 2019
25539ce
minor
iliakan May 13, 2019
928f42d
minor
iliakan May 13, 2019
0490fa2
Fix typos
lex111 May 13, 2019
383c3db
Fix typo
lex111 May 13, 2019
f5f31e8
Fix typo
lex111 May 13, 2019
899a3ce
fixes
iliakan May 14, 2019
9df9561
Order mismatch
him2312 May 14, 2019
e4288e4
minor
iliakan May 14, 2019
a956c4f
up
iliakan May 14, 2019
2c4cc64
up
iliakan May 15, 2019
c709aa1
up
iliakan May 15, 2019
4e079a5
Fix Typo (brewity to brevity)
gongzemin May 15, 2019
1072055
minor
iliakan May 15, 2019
89d81d3
Merge pull request #1 from javascript-tutorial/master
gongzemin May 15, 2019
0d2fc22
fix
iliakan May 15, 2019
c5fab43
Fix typo, so it actually does invoke the setter
CrazyTim May 15, 2019
d11039e
Merge pull request #981 from CrazyTim/CrazyTim-patch-1
iliakan May 15, 2019
bfb3819
Spelling mistake
him2312 May 15, 2019
c43c553
Merge pull request #984 from him2312/patch-3
iliakan May 15, 2019
44bae6a
Fix typo (brewity to brevity) (#980)
lex111 May 16, 2019
43f5821
added link to exist page
shamilDzhakeev May 16, 2019
b368f37
Use relative link
lex111 May 16, 2019
40a4e18
added link to exist page (#985)
lex111 May 16, 2019
d974090
fixes
iliakan May 16, 2019
39394b9
Changed "phrase" to "phase" for capture param
oonufrienko May 16, 2019
c5f4d5b
Changed "phrase" to "phase" for capture param (#987)
lex111 May 16, 2019
98d3962
minor
iliakan May 16, 2019
c52fd3e
Fix typo
lex111 May 16, 2019
55f599e
word correction (#989)
lex111 May 16, 2019
da3ba6a
closes #990
iliakan May 17, 2019
809cebc
closes #990
iliakan May 17, 2019
ee4a91e
fix
iliakan May 17, 2019
63ffc3d
Update article.md
developerdavo May 18, 2019
6bdaf20
Mobile Browser accessibility
him2312 May 18, 2019
a830dcc
Grammar
him2312 May 19, 2019
5e2a2a1
Grammar (#996)
lex111 May 19, 2019
f751b57
Fix typo in article.md (#993)
lex111 May 19, 2019
e7d6d4a
Merge pull request #995 from him2312/patch-5
iliakan May 19, 2019
dd106ba
class
iliakan May 19, 2019
00d8b63
minor
iliakan May 19, 2019
0f5e44e
Merge pull request #979 from him2312/patch-2
iliakan May 19, 2019
47c2d22
Update README.md
iliakan May 19, 2019
49264e2
minor
iliakan May 19, 2019
3e5db10
Fix a little typo.
May 19, 2019
b52dd6f
Fix a little typo. (#997)
lex111 May 19, 2019
5c6a3f0
fixes
iliakan May 19, 2019
f651e96
minor
iliakan May 19, 2019
d7834f2
Fixed an error in the 'An incomparable undefined' section. The value …
May 20, 2019
4ffbb3b
Grave accent
alfiya-udc May 20, 2019
2b804eb
minor
iliakan May 20, 2019
49aef00
fixes
iliakan May 20, 2019
6972b41
Merge pull request #999 from alfiya-udc/master
iliakan May 20, 2019
3ce2d96
Merge pull request #998 from GodAzaldin/master
iliakan May 20, 2019
6a1cccf
Some punctuation & sense ?
alfiya-udc May 21, 2019
7d6d436
minor
iliakan May 21, 2019
cfff5c1
minor
iliakan May 21, 2019
db32cd0
minor
iliakan May 21, 2019
7f1d5de
minor
iliakan May 21, 2019
a361825
Grave accent
alfiya-udc May 22, 2019
bdda1af
minor
iliakan May 23, 2019
9f7235d
minor
iliakan May 23, 2019
d421e02
Update article.md
maurodibert May 23, 2019
33e1243
change spelling
nabaraj May 23, 2019
df7800a
improvement
iliakan May 23, 2019
397ee9a
specifying the property inside Environment Record
Violet-Bora-Lee May 24, 2019
4594d12
update comment on sample code
Violet-Bora-Lee May 24, 2019
4d17a15
Merge pull request #1007 from Violet-Bora-Lee/patch-3
iliakan May 24, 2019
d8cc5c4
Merge pull request #1005 from nabaraj/patch-1
iliakan May 24, 2019
3a24b0a
Merge pull request #1006 from Violet-Bora-Lee/patch-2
iliakan May 24, 2019
4879734
Merge pull request #1004 from maurodibert/patch-47
iliakan May 24, 2019
c7ba283
typo
maurodibert May 25, 2019
2bc3aae
Merge pull request #1009 from maurodibert/patch-48
iliakan May 25, 2019
a2cb3c6
Update solution.md
maurodibert May 25, 2019
09db684
Merge pull request #1012 from maurodibert/patch-49
iliakan May 25, 2019
f8a00f4
Update solution.md
maurodibert May 25, 2019
3e6f2d0
Fix typos
KenjiI May 25, 2019
f0affb7
minor
iliakan May 25, 2019
a747a2c
delete wrong comment
T1mL3arn May 25, 2019
f10e34b
Merge pull request #1015 from T1mL3arn/patch-1
iliakan May 25, 2019
895b46a
Merge pull request #1014 from KenjiI/patch-3
iliakan May 25, 2019
9b03ee7
Merge pull request #1013 from maurodibert/patch-50
iliakan May 25, 2019
49fbecc
clear declarations
iliakan May 26, 2019
7df2a2a
Update article.md
maurodibert May 26, 2019
ebe532e
del redundant 'then'
T1mL3arn May 26, 2019
be235bc
Del redundant 'then' word (#1019)
lex111 May 26, 2019
4ac1def
Merge pull request #1016 from maurodibert/patch-51
iliakan May 26, 2019
fabf802
Update article.md
iliakan May 26, 2019
5c6a8ec
minor
iliakan May 26, 2019
5f095cc
improvements
iliakan May 26, 2019
c4f6b24
fix css comments
T1mL3arn May 27, 2019
297ae60
Change number of flags
vasilevx May 27, 2019
a9a0156
Merge pull request #1021 from vasilevx/patch-2
iliakan May 27, 2019
feebcc8
Merge pull request #1020 from T1mL3arn/master
iliakan May 27, 2019
0641d55
Fix typo
lex111 May 28, 2019
50d7cc2
minor
iliakan May 28, 2019
878ce62
Update article.md
tonchique May 28, 2019
5a91716
Update article.md
tonchique May 28, 2019
56365ae
minor
iliakan May 28, 2019
ae776d8
Fix Websocket article typo
skmetaly May 28, 2019
9adabf8
Merge pull request #1024 from skmetaly/fix-websocket-typo
iliakan May 28, 2019
fde93c9
Merge pull request #1023 from tonchique/patch-2
iliakan May 28, 2019
3dd9fb0
Merge pull request #1022 from tonchique/patch-1
iliakan May 28, 2019
16e7d07
Fix typos
lex111 May 29, 2019
0873473
minor
iliakan May 29, 2019
77ad4eb
Update article.md
tonchique May 30, 2019
e4300bb
Fix typo
DouglasMV May 30, 2019
8489afd
Update article.md
dhx-mike-palandra May 30, 2019
e1eb073
Fix chaters to chapters
sthamit7 May 31, 2019
39ea587
Merge pull request #1003 from alfiya-udc/master
iliakan May 31, 2019
49476f4
Merge pull request #1027 from DouglasMV/master
iliakan May 31, 2019
eb7e281
Merge pull request #1026 from tonchique/patch-3
iliakan May 31, 2019
267cf94
Merge pull request #1028 from dhx-mike-palandra/patch-1
iliakan May 31, 2019
ce863fe
Merge pull request #1029 from sthamit7/patch-1
iliakan May 31, 2019
0a58516
Update article.md
tonchique May 31, 2019
55ba660
Update article.md (#1030)
lex111 May 31, 2019
76b0616
improvements
iliakan May 31, 2019
9f4b8a5
minor
iliakan May 31, 2019
6713199
minor
iliakan May 31, 2019
389801a
minor
iliakan May 31, 2019
e4b2d76
Update article.md
dhx-mike-palandra May 31, 2019
d04805f
New V8 Blog address
raminrez Jun 1, 2019
8c96150
New V8 Blog address (#1035)
lex111 Jun 1, 2019
0e97922
fixes
iliakan Jun 1, 2019
c82abef
minor
iliakan Jun 1, 2019
b88b4dc
Merge pull request #1033 from dhx-mike-palandra/patch-2
iliakan Jun 1, 2019
7067d62
Fix typo
segayuu Jun 3, 2019
c4593f1
Merge pull request #1036 from segayuu/patch-1
iliakan Jun 3, 2019
13bd321
Update article.md
tonchique Jun 3, 2019
c92f626
fixes
iliakan Jun 3, 2019
a0266c5
Update article.md (#1037)
lex111 Jun 3, 2019
5736fe6
merging all conflicts
Jun 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor
  • Loading branch information
iliakan committed May 28, 2019
commit 56365aedf19b5702c2ee8bc5d4cb16b718a636b4
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ We want to find all tags, with or without attributes -- like `subject:<a href=".

In particular, we need it to match tags like `<a test="<>" href="#">` -- with `<` and `>` in attributes. That's allowed by [HTML standard](https://html.spec.whatwg.org/multipage/syntax.html#syntax-attributes).

Now we can see that a simple regexp like `pattern:<[^>]+>` doesn't work, because it stops at the first `>`, and we need to ignore `<>` if inside an attribute.
A simple regexp like `pattern:<[^>]+>` doesn't work, because it stops at the first `>`, and we need to ignore `<>` if inside an attribute:

```js run
// the match doesn't reach the end of the tag - wrong!
Expand All @@ -41,7 +41,7 @@ To correctly handle such situations we need a more complex regular expression. I

If we substitute these into the pattern above and throw in some optional spaces `pattern:\s`, the full regexp becomes: `pattern:<\w+(\s*\w+="[^"]*"\s*)*>`.

That regexp is not perfect! It doesn't yet support all details of HTML, for instance unquoted values, and there are other ways to improve, but let's not add complexity. It will demonstrate the problem for us.
That regexp is not perfect! It doesn't support all the details of HTML syntax, such as unquoted values, and there are other ways to improve, but let's not add complexity. It will demonstrate the problem for us.

The regexp seems to work:

Expand Down Expand Up @@ -222,6 +222,8 @@ The string has no `>` at the end, so the match is impossible, but the regexp eng
...
```

As there are many combinations, it takes a lot of time.

## How to fix?

The backtracking checks many variants that are an obvious fail for a human.
Expand Down