[재작업] 1-js/09-classes/02-class-inheritance 백틱수정및 재검토 #323

singularity-code · 2019-10-23T00:48:36Z

계속 실수가 많네요. 다시 검토해봤습니다.
감사합니다.

Violet-Bora-Lee

README의 번역규칙을 다시한번 읽어주세요.

맞춤법 검사기로 충분히 잡을 수 있는 오류들이 남아있습니다.
과제 먼저 리뷰하다가 아직 컨벤션 숙지가 안되어계신것같아서 본문 리뷰는 추후 진행하도록 하겠습니다.

1-js/09-classes/02-class-inheritance/3-class-extend-object/task.md

1-js/09-classes/02-class-inheritance/1-class-constructor-error/solution.md

1-js/09-classes/02-class-inheritance/1-class-constructor-error/task.md

1-js/09-classes/02-class-inheritance/2-clock-class-extended/task.md

1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md

javascript-translate-bot · 2019-10-23T13:07:45Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Violet-Bora-Lee · 2019-10-23T13:10:26Z

PR 요청 후 어떤 부분이 수정되었는지 line by line으로 확인해주세요.

1-js/09-classes/02-class-inheritance/article.md

1-js/09-classes/02-class-inheritance/2-clock-class-extended/task.md

1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md

1-js/09-classes/02-class-inheritance/3-class-extend-object/task.md

1-js/09-classes/02-class-inheritance/article.md

Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/task.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/article.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/2-clock-class-extended/task.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md Co-Authored-By: Ju Yeong <[email protected]> Update 1-js/09-classes/02-class-inheritance/3-class-extend-object/solution.md Co-Authored-By: Ju Yeong <[email protected]> [클래스상속] 리뷰반영 및 오류수정

Violet-Bora-Lee · 2019-10-25T04:22:27Z

@JuYeong0413님이 리뷰 봐주 셨는데, 타임라인 보니까 이 글 하나 리뷰에만 못해도 3시간이 걸렸어요... 정말 기본적인 것들이 안 지켜지고 있어서 mainter나 committer가 @singularity-code
님의 작업을 확인하는데 많은 시간이 소요되고있습니다. 컨벤션 숙지 후 작업해주시길 부탁드립니다.

Violet-Bora-Lee

수정부탁드립니다.

다른 커밋이 섞여있어요.

PR생성전에 꼭!! 본인의 작업을 확인해주세요......

Violet-Bora-Lee · 2019-10-25T04:27:59Z

1-js/06-advanced-functions/01-recursion/01-sum-to/solution.md

@@ -1,4 +1,4 @@
-반복문 사용하기:
+반복문 사용하기


여기는 :를 왜 빼셨나요?

끄아아아아~~ squash rebase 하다 잘못 합쳐진듯 합니다!! ㅠㅠ

Violet-Bora-Lee · 2019-10-25T04:28:10Z

1-js/06-advanced-functions/01-recursion/01-sum-to/solution.md

@@ -12,7 +12,7 @@ function sumTo(n) {
 alert( sumTo(100) );
 ```

-재귀 사용하기:
+재귀 사용하기


여기는 :를 왜 빼셨나요?

살려주세요!!!

Violet-Bora-Lee · 2019-10-25T04:28:15Z

1-js/06-advanced-functions/01-recursion/01-sum-to/solution.md

@@ -23,7 +23,7 @@ function sumTo(n) {
 alert( sumTo(100) );
 ```

-등차수열의 합공식 `sumTo(n) = n*(n+1)/2` 사용하기:
+등차수열의 합공식 `sumTo(n) = n*(n+1)/2` 사용하기


여기는 :를 왜 빼셨나요?

Violet-Bora-Lee · 2019-10-25T04:28:20Z

1-js/06-advanced-functions/01-recursion/02-factorial/task.md

@@ -11,7 +11,7 @@ importance: 4
 n! = n * (n - 1) * (n - 2) * ...*1
 ```

-자연수 `n`에 대한 `n` 팩토리얼:
+자연수 `n`에 대한 `n` 팩토리얼


여기는 :를 왜 빼셨나요?

Violet-Bora-Lee · 2019-10-25T04:28:34Z

1-js/06-advanced-functions/01-recursion/03-fibonacci-numbers/solution.md

 The first solution we could try here is the recursive one.
+첫번째 해결방법은 재귀를 이용한 것입니다.

 Fibonacci numbers are recursive by definition:
+피보나치 수들은 정의에 따라 재귀적입니다.


원문이 남아있습니다.

끄아아아.. 다른 브랜치인데 같이 합쳐졌어요 ㅠㅠ 수정하겠습니다

Violet-Bora-Lee · 2019-10-25T04:28:46Z

1-js/06-advanced-functions/01-recursion/03-fibonacci-numbers/solution.md

 ```

 ...But for big values of `n` it's very slow. For instance, `fib(77)` may hang up the engine for some time eating all CPU resources.
+...하지만 `n`의 값이 클경우 매우 느립니다. 예를 들어,`fib (77)`은 한동안 모든 CPU 리소스를 먹어서 자바스크립트 엔진을 정지시킬 수 있습니다.


맨 앞 ...을 빼주세요

javascript-translate-bot · 2019-10-25T04:29:24Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Violet-Bora-Lee · 2019-10-25T04:39:39Z

깃 공부를 더 하셔야할것같아요.
번역은 깃 사용법을 아시고, 자바스크립트 공부하고 싶으신분이 하셔야 프로젝트에도, 커미터에게도 도움이 됩니다.
저희 프로젝트는 이제 쉬시고 깃 공부 하시는게 나을것같아요.

singularity-code · 2019-10-25T05:05:43Z

맞아요. @JuYeong0413님도 저때문에 많은 시간을 소모하신것 같더라구요.
제 작업은 점점 더 퀄리리티가 안좋아지네요. 제가 공부더 안한것도 있구요. 얘기는 깊이 공감합니다.
완료할수있으면 하는데까지 하고 쉬도록 할게요. 두분에게는 언젠가 맛있는걸 사드리겠습니다 ㅎ; 감사해요

javascript-translate-bot added the review needed label Oct 23, 2019

javascript-translate-bot requested a review from a team October 23, 2019 00:48

Violet-Bora-Lee requested changes Oct 23, 2019

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Oct 23, 2019