Skip to content

Sync with upstream @ 2b5ac971 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 633 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
633 commits
Select commit Hold shift + click to select a range
bb97418
fixes #1469
iliakan Oct 17, 2019
23e9175
Update article.md
iliakan Oct 17, 2019
3a90d94
Merge pull request #1464 from hrodward/patch-5
iliakan Oct 17, 2019
615609e
Merge pull request #1467 from hrodward/patch-7
iliakan Oct 17, 2019
5197701
Merge pull request #1466 from hrodward/patch-6
iliakan Oct 17, 2019
bb2a259
Merge pull request #1465 from hrodward/patch-4
iliakan Oct 17, 2019
da8af69
Update article.md
hrodward Oct 17, 2019
6a8b314
Update article.md
iliakan Oct 17, 2019
ee80b55
add test case for debounce
dagolinuxoid Oct 17, 2019
32f8f0e
Merge pull request #1474 from dagolinuxoid/patch-2
iliakan Oct 17, 2019
eb2b6c9
Update article.md
paroche Oct 17, 2019
4452139
Update article.md
paroche Oct 18, 2019
33e4cc2
Update article.md
paroche Oct 18, 2019
81a2503
Update article.md
hrodward Oct 18, 2019
5ac537f
Update article.md
hrodward Oct 18, 2019
a2b45a8
Update task.md
hrodward Oct 18, 2019
2ffc997
Update solution.md
hrodward Oct 18, 2019
01352c1
minor
iliakan Oct 18, 2019
a52a643
minor
iliakan Oct 18, 2019
ee6f0ac
minor
iliakan Oct 18, 2019
d5f4fe9
minor
iliakan Oct 19, 2019
58c91c3
minor changes in grammar
Darryl1702 Oct 19, 2019
5b795f7
minor
Darryl1702 Oct 19, 2019
e8d86d9
minor
Darryl1702 Oct 19, 2019
a960984
minor
Darryl1702 Oct 19, 2019
7d1e1ba
Update article.md (#1478)
lex111 Oct 19, 2019
501bdf6
Merge pull request #1480 from hrodward/patch-12
iliakan Oct 19, 2019
edfc79d
Merge pull request #1479 from hrodward/patch-11
iliakan Oct 19, 2019
6634181
Merge pull request #1477 from hrodward/patch-10
iliakan Oct 19, 2019
3483424
Merge pull request #1476 from hrodward/patch-9
iliakan Oct 19, 2019
1fe192d
Merge pull request #1475 from javascript-tutorial/paroche-patch-3
iliakan Oct 19, 2019
f75439f
Merge pull request #1485 from Ghost-017/patch-7
iliakan Oct 19, 2019
f0e848a
minor
iliakan Oct 19, 2019
4088e5d
Merge pull request #1482 from Ghost-017/patch-4
paroche Oct 19, 2019
15d0394
Update article.md
paroche Oct 20, 2019
79e2447
Update article.md
paroche Oct 20, 2019
676ffb7
Update article.md
paroche Oct 20, 2019
8826f07
Update article.md
paroche Oct 20, 2019
ebd69e2
Merge pull request #1486 from javascript-tutorial/paroche-patch-4
iliakan Oct 20, 2019
4c9c943
Merge pull request #1484 from Ghost-017/patch-6
iliakan Oct 20, 2019
30e3fa7
minor
iliakan Oct 20, 2019
aae1e26
Update article.md
Darryl1702 Oct 20, 2019
14e82d1
minor
Darryl1702 Oct 20, 2019
74ad826
Update article.md
hrodward Oct 21, 2019
cc3c01b
Update task.md
hrodward Oct 21, 2019
cd97f84
Update article.md
hrodward Oct 21, 2019
5c6be4c
Update article.md
hrodward Oct 21, 2019
8c1b767
Update article.md
hrodward Oct 21, 2019
3c8ae30
Update article.md
hrodward Oct 21, 2019
906dd13
Update task.md
hrodward Oct 21, 2019
7500898
Update task.md
hrodward Oct 21, 2019
c0fd76b
Update task.md
hrodward Oct 21, 2019
89c4a0f
Update article.md
hrodward Oct 21, 2019
4bb52fb
Update task.md
hrodward Oct 21, 2019
2d77eb7
Merge pull request #1483 from Ghost-017/patch-5
iliakan Oct 21, 2019
2cbed98
minor
iliakan Oct 21, 2019
77e9317
Merge pull request #1487 from hrodward/patch-13
iliakan Oct 21, 2019
ea50619
Merge pull request #1488 from hrodward/patch-14
iliakan Oct 21, 2019
ddf9d1e
Merge pull request #1489 from hrodward/patch-15
iliakan Oct 21, 2019
5db94bb
Merge pull request #1490 from hrodward/patch-16
iliakan Oct 21, 2019
e577658
Merge pull request #1491 from hrodward/patch-17
iliakan Oct 21, 2019
e5674cf
Merge pull request #1493 from hrodward/patch-19
iliakan Oct 21, 2019
e661044
Merge pull request #1494 from hrodward/patch-20
iliakan Oct 21, 2019
50aa158
Merge pull request #1495 from hrodward/patch-21
iliakan Oct 21, 2019
5aea931
Merge pull request #1496 from hrodward/patch-22
iliakan Oct 21, 2019
040aea0
Merge pull request #1497 from hrodward/patch-23
iliakan Oct 21, 2019
7a6a566
minor
iliakan Oct 21, 2019
09d2e96
Update article.md
paroche Oct 21, 2019
7a0fbdb
Update article.md
paroche Oct 21, 2019
88cd022
Update article.md
lex111 Oct 21, 2019
dd52fb9
Fixed object variable user.go() to be obj.go()
Oct 21, 2019
022c037
Update article.md
paroche Oct 22, 2019
00d3f99
Merge pull request #1499 from javascript-tutorial/paroche-patch-5
paroche Oct 22, 2019
f430bea
Update article.md
paroche Oct 22, 2019
0932380
Update article.md
paroche Oct 22, 2019
d0b95aa
Update 1-js/08-prototypes/01-prototype-inheritance/article.md
hrodward Oct 22, 2019
6219338
Update article.md
hrodward Oct 22, 2019
a04d80c
Update article.md
hrodward Oct 22, 2019
9151079
Fixed object variable user.go() to be obj.go() (#1498)
lex111 Oct 22, 2019
01bb684
Merge pull request #1471 from hrodward/patch-8
iliakan Oct 22, 2019
c07eb5c
Update article.md
paroche Oct 22, 2019
29ea890
Merge branch 'master' into patch-18
lex111 Oct 22, 2019
2e5fa78
minor
iliakan Oct 22, 2019
00ebc81
Update article.md
hrodward Oct 22, 2019
33cca1b
Fix confusion in the task
lex111 Oct 22, 2019
b6404a6
Update article.md
hrodward Oct 23, 2019
ab55453
Update article.md
hrodward Oct 23, 2019
6f8ad3c
Update article.md
hrodward Oct 23, 2019
ad939bb
Update article.md
hrodward Oct 23, 2019
cc3795f
Update article.md
paroche Oct 24, 2019
f6ead73
Update article.md
paroche Oct 24, 2019
c8e062f
Update article.md
paroche Oct 24, 2019
f954987
Update article.md
paroche Oct 24, 2019
a2d32ad
Update article.md (#1506)
lex111 Oct 24, 2019
c4914ae
Update article.md
hrodward Oct 24, 2019
eb2b327
Update task.md
hrodward Oct 24, 2019
fab771f
Update article.md (#1511)
lex111 Oct 24, 2019
373a305
Update article.md (#1510)
lex111 Oct 24, 2019
31d96a3
Update article.md (#1509)
lex111 Oct 24, 2019
7f28d56
Update article.md (#1507)
lex111 Oct 24, 2019
0007368
Update article.md
hrodward Oct 25, 2019
7df2a19
Update article.md (#1517)
lex111 Oct 25, 2019
072fa7d
minor
iliakan Oct 25, 2019
ead158a
Update article.md
hrodward Oct 25, 2019
9909b90
minor
iliakan Oct 25, 2019
c62c84c
Merge pull request #1492 from hrodward/patch-18
iliakan Oct 25, 2019
321519e
Merge pull request #1518 from hrodward/patch-22
iliakan Oct 25, 2019
86891b9
Merge pull request #1514 from hrodward/patch-32
iliakan Oct 25, 2019
fac4413
Merge pull request #1504 from hrodward/patch-24
iliakan Oct 25, 2019
8d3fbcc
Fix typo.
carsca Oct 25, 2019
a0168c7
Update article.md
hrodward Oct 25, 2019
f2501bc
fix typo (#1520)
lex111 Oct 25, 2019
2bd1854
Update solution.md
hrodward Oct 25, 2019
d048324
Merge pull request #1505 from hrodward/patch-25
iliakan Oct 26, 2019
ec91bab
Merge pull request #1521 from hrodward/patch-24
iliakan Oct 26, 2019
db1e31b
Merge pull request #1519 from hrodward/patch-22
iliakan Oct 26, 2019
70ca842
minor
iliakan Oct 26, 2019
2a82d42
Update article.md
hrodward Oct 28, 2019
6a9bfe1
Update article.md
hrodward Oct 28, 2019
e70f039
string outputs without quotes
lumosmind Oct 28, 2019
bfb9b89
Update article.md
Violet-Bora-Lee Oct 28, 2019
b5725a8
'str' inside of 'start'
lumosmind Oct 28, 2019
8f85ab4
Update article.md (#1525)
lex111 Oct 28, 2019
e15a63c
Update article.md (#1526)
lex111 Oct 28, 2019
c06f0dd
string outputs without quotes (#1527)
lex111 Oct 28, 2019
2774d33
Update article.md (#1528)
lex111 Oct 28, 2019
4159a65
'str' inside of 'start' (#1529)
lex111 Oct 28, 2019
07a21c8
add attribute defination to arr.find()
lumosmind Oct 28, 2019
7371945
Missed function expression semicolon
iArazar Oct 28, 2019
24a6d29
Update article.md
Violet-Bora-Lee Oct 28, 2019
83cdced
fix a minor bug in the example
TomSssM Oct 28, 2019
634531a
Array type variables also supports values()
lumosmind Oct 28, 2019
d5195b5
closes #1524 #716
iliakan Oct 29, 2019
9fb2076
correction for code template consistency
lumosmind Oct 29, 2019
00bacf6
Removed extra "and" in a sentence
yogain123 Oct 29, 2019
3e48d52
Update article.md
hrodward Oct 29, 2019
54717a1
Update solution.md
hrodward Oct 29, 2019
b32ce2c
coding style conflict with the tutorial itself
lumosmind Oct 29, 2019
95495bd
linked list must end with 'null'
lumosmind Oct 29, 2019
2fd1a4e
removes russian text chunk from english text
TobiObeck Oct 29, 2019
d8958e2
Update article.md (#1533)
lex111 Oct 29, 2019
23778ed
removes russian text chunk from english text (#1544)
lex111 Oct 29, 2019
0998fce
Removed extra "and" in a sentence (#1537)
lex111 Oct 29, 2019
7510263
correction for code template consistency (#1536)
lex111 Oct 29, 2019
97cd2fc
function declaration vs function call conflict
lumosmind Oct 29, 2019
c5c94bc
closes #1547
iliakan Oct 29, 2019
e8947f7
Merge pull request #1546 from lumosmind/patch-14
iliakan Oct 29, 2019
bb3f9aa
Merge pull request #1543 from lumosmind/patch-12
iliakan Oct 29, 2019
2964aa0
Merge pull request #1542 from lumosmind/patch-11
iliakan Oct 29, 2019
8d45a7c
Merge pull request #1539 from hrodward/patch-35
iliakan Oct 29, 2019
77eedd8
Merge pull request #1538 from hrodward/patch-34
iliakan Oct 29, 2019
726f2a8
Merge pull request #1535 from lumosmind/patch-7
iliakan Oct 29, 2019
d4eaaf4
Merge pull request #1534 from TomSssM/patch-1
iliakan Oct 29, 2019
be6856d
closes #1532
iliakan Oct 29, 2019
4d02719
Merge pull request #1531 from iArazar/patch-1
iliakan Oct 29, 2019
601d958
Merge pull request #1530 from lumosmind/patch-5
iliakan Oct 29, 2019
028b408
Update article.md
hrodward Oct 29, 2019
ccccf10
Update article.md
hrodward Oct 30, 2019
c72735d
Update article.md
hrodward Oct 30, 2019
04893ae
arrow function instead of function
lumosmind Oct 30, 2019
aecf899
code non-compatible with clarification drawing
lumosmind Oct 30, 2019
80b6da1
code non-compatible with clarification drawing
lumosmind Oct 30, 2019
71fb491
minor
iliakan Oct 30, 2019
df58d3f
Merge pull request #1513 from hrodward/patch-31
lex111 Oct 30, 2019
1257501
Update article.md
hrodward Oct 31, 2019
5f37ad1
Update article.md
hrodward Oct 31, 2019
563d0a4
Update task.md
hrodward Oct 31, 2019
487c317
fix mini typo
richardzhanghub Oct 31, 2019
1bc2c9a
fix mini typo (#1559)
lex111 Oct 31, 2019
2a6d840
Fix syntax error
ogaclejapan Nov 1, 2019
107e5df
Merge pull request #1561 from ogaclejapan/fix-syntax
iliakan Nov 1, 2019
f3e4541
Merge pull request #1558 from hrodward/patch-36
iliakan Nov 1, 2019
b8dcadf
Merge pull request #1557 from hrodward/patch-35
iliakan Nov 1, 2019
eebbaa2
Merge pull request #1556 from hrodward/patch-31
iliakan Nov 1, 2019
80f3954
Merge pull request #1555 from lumosmind/patch-20
iliakan Nov 1, 2019
06c9dfe
Merge pull request #1554 from lumosmind/patch-19
iliakan Nov 1, 2019
24d3bec
Merge pull request #1553 from lumosmind/patch-18
iliakan Nov 1, 2019
7fcd048
Merge pull request #1551 from hrodward/patch-34
iliakan Nov 1, 2019
b2305ce
Merge pull request #1550 from hrodward/patch-22
iliakan Nov 1, 2019
81f171e
wrapper instead of helper
lumosmind Nov 2, 2019
da15e57
bug fix on the server
TomSssM Nov 2, 2019
a967ad0
closes #1560
iliakan Nov 2, 2019
ad08b46
fixes #1563
iliakan Nov 2, 2019
7f5fced
Merge pull request #1564 from lumosmind/patch-23
iliakan Nov 2, 2019
6732cef
fix
iliakan Nov 2, 2019
d4fd448
Merge pull request #1566 from TomSssM/tomsssm-patch-2
iliakan Nov 2, 2019
611fefd
fixes #1569
iliakan Nov 3, 2019
3ffa0be
minor fixes
Violet-Bora-Lee Nov 3, 2019
ec21af8
Merge pull request #1570 from Violet-Bora-Lee/master
iliakan Nov 3, 2019
7d92be9
Update article.md
paroche Nov 4, 2019
9e7235f
Update article.md
paroche Nov 4, 2019
580221f
Update article.md
paroche Nov 4, 2019
4541b04
Update solution.md
paroche Nov 4, 2019
b43e954
Merge pull request #1572 from javascript-tutorial/paroche-patch-6
paroche Nov 4, 2019
f37e9e7
trivial: indefinite to definite article
petrem Nov 4, 2019
8dfb5e8
Update article.md
hrodward Nov 4, 2019
fccf461
Update task.md
hrodward Nov 4, 2019
9f158f9
Update article.md
hrodward Nov 4, 2019
dcb9d87
trivial: indefinite to definite article (#1573)
lex111 Nov 4, 2019
6dec3cc
Update article.md
hrodward Nov 5, 2019
7e3e74f
"syntactic sugar" instead of "syntax sugar"
lumosmind Nov 5, 2019
7b47d37
Update article.md
hrodward Nov 5, 2019
0f91236
computed property name instead of computed propert
lumosmind Nov 5, 2019
4df1cb9
not proved features of class properties
lumosmind Nov 5, 2019
11ec672
example code must be unexecutable
lumosmind Nov 5, 2019
c905bda
prove of concept
lumosmind Nov 5, 2019
cd4def5
example code must be unexecutable (#1586)
lex111 Nov 5, 2019
7ca5f53
"syntactic sugar" instead of "syntax sugar" (#1582)
lex111 Nov 5, 2019
5f540e5
Update 01-regexp-introduction
wgolledge Nov 5, 2019
f9b91e2
Update article.md
paroche Nov 6, 2019
7c8508c
Update article.md
paroche Nov 6, 2019
6165a9a
split arrow functions
iliakan Nov 6, 2019
2aedc2d
refactor arrow functions
iliakan Nov 6, 2019
ecd93e9
fixes
iliakan Nov 6, 2019
978a3a2
Merge pull request #1590 from wgolledge/patch-1
iliakan Nov 6, 2019
2063dbd
closes #1592
iliakan Nov 6, 2019
29c4fc6
closes #1589
iliakan Nov 6, 2019
763a639
Merge pull request #1588 from lumosmind/patch-36
iliakan Nov 6, 2019
dcc7e48
Merge pull request #1571 from javascript-tutorial/paroche-patch-5
iliakan Nov 6, 2019
cb8ca5c
Merge pull request #1574 from hrodward/patch-22
iliakan Nov 6, 2019
7aa527c
Merge pull request #1575 from hrodward/patch-31
iliakan Nov 6, 2019
57e9dc8
Merge pull request #1578 from hrodward/patch-34
iliakan Nov 6, 2019
8b54520
Merge pull request #1580 from hrodward/patch-35
iliakan Nov 6, 2019
8734416
minor
iliakan Nov 6, 2019
d88da8a
Merge pull request #1583 from hrodward/patch-36
iliakan Nov 6, 2019
c78cfdf
Merge pull request #1584 from lumosmind/patch-30
iliakan Nov 6, 2019
7c691b4
Merge pull request #1585 from lumosmind/patch-31
iliakan Nov 6, 2019
f12e89a
Update article.md
dashaezhova Nov 7, 2019
3955844
minor
iliakan Nov 7, 2019
5a1825c
Update article.md (#1593)
lex111 Nov 7, 2019
94e251d
Fixed Typo
embok345 Nov 7, 2019
1afdc8f
Update article.md
paroche Nov 8, 2019
1bccdbb
Merge pull request #1596 from javascript-tutorial/paroche-patch-6
paroche Nov 8, 2019
7279e9c
Update article.md
paroche Nov 8, 2019
cb3aadc
Update article.md
paroche Nov 8, 2019
83bfe33
Update article.md
paroche Nov 8, 2019
b071f46
Update article.md
paroche Nov 8, 2019
d6b9f74
Update article.md
paroche Nov 8, 2019
b2e53ef
Fixed Typo (#1595)
lex111 Nov 8, 2019
53ae1bb
Fix link
lex111 Nov 8, 2019
aa97ba0
Update task.md
paroche Nov 8, 2019
012e536
Update article.md
paroche Nov 9, 2019
37d8255
Update article.md
paroche Nov 9, 2019
5be8789
Update article.md
paroche Nov 9, 2019
83bf32f
Merge pull request #1598 from javascript-tutorial/paroche-patch-8
paroche Nov 9, 2019
64acea4
Update article.md
paroche Nov 9, 2019
aab70cd
Update article.md
paroche Nov 10, 2019
be244d0
Update article.md
paroche Nov 10, 2019
2b5ac97
minor
iliakan Nov 10, 2019
e62ebe8
merging all conflicts
iliakan Nov 11, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update article.md
Grammar suggestions
  • Loading branch information
hrodward authored Oct 24, 2019
commit c4914ae803f8b40b458fb02b5641cba743f12e17
10 changes: 5 additions & 5 deletions 1-js/09-classes/06-instanceof/article.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

The `instanceof` operator allows to check whether an object belongs to a certain class. It also takes inheritance into account.

Such a check may be necessary in many cases, here we'll use it for building a *polymorphic* function, the one that treats arguments differently depending on their type.
Such a check may be necessary in many cases. Here we'll use it for building a *polymorphic* function, the one that treats arguments differently depending on their type.

## The instanceof operator [#ref-instanceof]

Expand Down Expand Up @@ -46,7 +46,7 @@ alert( arr instanceof Object ); // true

Please note that `arr` also belongs to the `Object` class. That's because `Array` prototypically inherits from `Object`.

Normally, `instanceof` operator examines the prototype chain for the check. We can also set a custom logic in the static method `Symbol.hasInstance`.
Normally, `instanceof` examines the prototype chain for the check. We can also set a custom logic in the static method `Symbol.hasInstance`.

The algorithm of `obj instanceof Class` works roughly as follows:

Expand All @@ -68,7 +68,7 @@ The algorithm of `obj instanceof Class` works roughly as follows:
alert(obj instanceof Animal); // true: Animal[Symbol.hasInstance](obj) is called
```

2. Most classes do not have `Symbol.hasInstance`. In that case, the standard logic is used: `obj instanceOf Class` checks whether `Class.prototype` equals to one of prototypes in the `obj` prototype chain.
2. Most classes do not have `Symbol.hasInstance`. In that case, the standard logic is used: `obj instanceOf Class` checks whether `Class.prototype` equals to any prototype in the `obj` prototype chain.

In other words, compare one after another:
```js
Expand Down Expand Up @@ -107,7 +107,7 @@ By the way, there's also a method [objA.isPrototypeOf(objB)](mdn:js/object/isPro

It's funny, but the `Class` constructor itself does not participate in the check! Only the chain of prototypes and `Class.prototype` matters.

That can lead to interesting consequences when `prototype` property is changed after the object is created.
That can lead to interesting consequences when a `prototype` property is changed after the object is created.

Like here:

Expand Down Expand Up @@ -186,7 +186,7 @@ let user = {
alert( {}.toString.call(user) ); // [object User]
```

For most environment-specific objects, there is such a property. Here are few browser specific examples:
For most environment-specific objects, there is such a property. Here are some browser specific examples:

```js run
// toStringTag for the environment-specific object and class:
Expand Down