Skip to content

Provide feedback when inserting notes using f1-f12 step input. #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Conversation

jcsteh
Copy link
Owner

@jcsteh jcsteh commented May 19, 2025

Fixes #1247.
I've tested this, but additional testing and scrutiny would be ideal:

  1. Normal insertion (i and shift+i), since I heavily refactored that code to make it reusable for f1-f12 step input.
  2. F1-f12 in the MIDI editor without step input enabled (to make sure I didn't somehow break these).
  3. Step input with f1-f12 (advances cursor).
  4. Step input with shift+f1-f12 (does not advance cursor).

Copy link
Contributor

Build 134 failed!

Copy link
Contributor

@ScottChesworth
Copy link
Collaborator

Done the suggested testing and this is all working very goodly. I only have two questions (only he says, as if one of them isn't going to be the sort of question that'll make you sigh like an old bike tyre).

  1. Unmodified FKeys advancing cursor and Shift+FKeys not advancing is the opposite of how I and Shift+I work. It doesn't make sense to have people holding Shift for what will obviously be the more useful scenario, so I thought we'll swap I and Shift+I. Then I thought about how much learning material that's difficult/impossible to update it'll invalidate. Then I thought... heeeeelp!
  2. Is Shift+FKeys a REAPER function or something you coded? If the latter, would you be open to Shift inserting octave down from the pitch cursor instead, still advancing cursor? Looks like the actions are there for it.

@jcsteh
Copy link
Owner Author

jcsteh commented May 19, 2025

1. Unmodified FKeys advancing cursor and Shift+FKeys not advancing is the opposite of how I and Shift+I work.

is it?

  • Edit: Insert note at edit cursor: I or NumPad5
  • Edit: Insert note at edit cursor (no advance edit cursor): Shift+I or Shift+NumPad5
2. Is Shift+FKeys a REAPER function or something you coded?

REAPER. It's not clear that this will happen though; i discovered it by mistake.

@jcsteh
Copy link
Owner Author

jcsteh commented May 19, 2025

Shift inserting octave down from the pitch cursor instead, still advancing cursor? Looks like the actions are there for it.

I don't use the actions here; I let REAPER handle the key. Recall that those actions never advance the cursor.

@ScottChesworth
Copy link
Collaborator

Fiddlesticks! The ReadMe is wrong about I and Shift+I. Those actions got switched around years ago, and in slightly more recent times both keystrokes got bound to custom actions that preserve rectangle note shapes, because users kept getting caught out by differing behaviour of the others. Sorry, no idea how that's slipped through for so long.
Lemme quiz some users who do note insertion a lot, see how mad they'd be if I make these two things consistent.

@jcsteh
Copy link
Owner Author

jcsteh commented May 19, 2025

Why did they get switched around anyway, if even you're saying that advancing is the more common scenario?

@ScottChesworth
Copy link
Collaborator

I don't remember the rationale that won out. Was back in the key map consortium group days, half a bazillion voice notes per decision so not easy to search. I'm checking which training materials it would impact now, feels like a lot, but I do tend to react quite strongly to fragmentation, it might not be so bad.

@jcsteh
Copy link
Owner Author

jcsteh commented May 20, 2025

Done the suggested testing and this is all working very goodly.

Merging on that basis, since none of the other stuff here is specifically related to this change.

@jcsteh jcsteh merged commit a0bc141 into master May 20, 2025
3 checks passed
@jcsteh jcsteh deleted the step branch May 20, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advice needed: trying to implement playing note previews when using FKeys for step input
2 participants