-
Notifications
You must be signed in to change notification settings - Fork 47
Provide feedback when inserting notes using f1-f12 step input. #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Done the suggested testing and this is all working very goodly. I only have two questions (only he says, as if one of them isn't going to be the sort of question that'll make you sigh like an old bike tyre).
|
is it?
REAPER. It's not clear that this will happen though; i discovered it by mistake. |
I don't use the actions here; I let REAPER handle the key. Recall that those actions never advance the cursor. |
Fiddlesticks! The ReadMe is wrong about I and Shift+I. Those actions got switched around years ago, and in slightly more recent times both keystrokes got bound to custom actions that preserve rectangle note shapes, because users kept getting caught out by differing behaviour of the others. Sorry, no idea how that's slipped through for so long. |
Why did they get switched around anyway, if even you're saying that advancing is the more common scenario? |
I don't remember the rationale that won out. Was back in the key map consortium group days, half a bazillion voice notes per decision so not easy to search. I'm checking which training materials it would impact now, feels like a lot, but I do tend to react quite strongly to fragmentation, it might not be so bad. |
Merging on that basis, since none of the other stuff here is specifically related to this change. |
Fixes #1247.
I've tested this, but additional testing and scrutiny would be ideal: