Skip to content

Removed a few unnecessary heap allocations #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Removed a few unnecessary heap allocations #186

wants to merge 5 commits into from

Conversation

jonathanmarvens
Copy link

@jonathanmarvens jonathanmarvens commented Apr 19, 2024 •
edited
Loading

This is just a minor update to remove a few unnecessary heap allocations.

@karpathy
Copy link
Owner

i like the allocations fix but not sure about the types fix

@jonathanmarvens
Copy link
Author

@karpathy I’ve moved the types update to a separate PR (#188), so you can evaluate it in isolation.

@jonathanmarvens jonathanmarvens mentioned this pull request Apr 19, 2024
Open
@jonathanmarvens
Copy link
Author

@karpathy I just fixed the merge conflicts. Is there anything holding this PR back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanmarvens @karpathy