zstd: Fix reuse of huff0 when data hard to compress #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstd would reject huff0 compressed literals if the improvement was too small. However, this would update the huff0 state to contain a new table which could be reused. In that case a wrong table could be used for the next block. We move the rejection code to huff0, so the state can be properly maintained. Fixes #170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstd would reject huff0 compressed literals if the improvement was too small.
However, this would update the huff0 state to contain a new table which could be reused. In that case a wrong table could be used for the next block.
We move the rejection code to huff0, so the state can be properly maintained.
Fixes #170