Skip to content

Add a channel for Persian docs#4980

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
zacharysarah:add-persian-channel
Jul 27, 2020
Merged

Add a channel for Persian docs#4980
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
zacharysarah:add-persian-channel

Conversation

@zacharysarah

@zacharysarah zacharysarah commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Fixes #4979

/assign @sftim @jimangel @kbarnard10

Holding for 👍 from @sattarfeizollahibarough
/hold

/sig docs
/language fa

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 21, 2020
@k8s-ci-robot

k8s-ci-robot commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

@zacharysarah: The label(s) language/fa cannot be applied, because the repository doesn't have them

Details

In response to this:

Fixes #4979

/assign @sftim @jimangel @kbarnard10

Holding for 👍 from @sattarfeizollahibarough
/hold

/sig docs
/language fa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jul 21, 2020
@k8s-ci-robot

k8s-ci-robot commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@zacharysarah

zacharysarah commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

@spiffxp 👋 Do we need to do anything to propagate kubernetes/test-infra#18369 to other repos?

Screen Shot 2020-07-20 at 6 00 09 PM

@zacharysarah zacharysarah mentioned this pull request Jul 21, 2020
Merged
@jimangel

jimangel commented Jul 21, 2020

Copy link
Copy Markdown
Member

/lgtm (for when hold is lifted)

@zacharysarah

zacharysarah commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@parispittman

parispittman commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6eee492 into kubernetes:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@castrojo castrojo Awaiting requested review from castrojo

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@jimangel jimangel

@parispittman parispittman

@kbarnard10 kbarnard10

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REQUEST: New Slack channel kubernetes-docs-fa

6 participants

@zacharysarah @k8s-ci-robot @jimangel @parispittman @kbarnard10 @sftim