Skip to content

Adding maintainer responsibilities, off-boarding, and emeritus governance docs#366

Merged
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
aburdenthehand:maintainer-mentorship
Jan 24, 2025
Merged

Adding maintainer responsibilities, off-boarding, and emeritus governance docs#366
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
aburdenthehand:maintainer-mentorship

Conversation

@aburdenthehand

Copy link
Copy Markdown
Member
  1. Adding maintainer responsibilities, since we mention this as part of our selection criteria.
  2. Also adding off-boarding/retiring expectations for maintainers, something we've been talking about throughout the year but never put into our docs. It is also a part of CNCF graduation criteria, so let's put it into our docs.
  3. Also also adding an opening para that links to our membership policy, to make that more obvious for anyone looking for that info in our governance doc. This is mirrored by adding project maintainers to our contribution ladder in the membership policy, linking back to governance, and to our maintainers file.

Fixes #311

As per our governance, this requires a 2/3 vote of maintainers to update.
/cc @fabiand @davidvossel @rthallisey @rmohr @vasiliy-ul @vladikr @stu-gott

Release note:

Adding responsibilities and offboarding expectations for maintainers

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Dec 10, 2024
@vladikr

vladikr commented Dec 15, 2024

Copy link
Copy Markdown
Member

Thanks @aburdenthehand
We discussed this offline as well.
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2024
@kubevirt-bot

Copy link
Copy Markdown
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Dec 22, 2024

@iholder101 iholder101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aburdenthehand!
Looks great to me. Left some nits.

/lgtm

Comment thread GOVERNANCE.md Outdated
Comment thread GOVERNANCE.md
Comment thread GOVERNANCE.md Outdated
Comment thread GOVERNANCE.md Outdated
@stu-gott

Copy link
Copy Markdown
Member

👍 from me

@rthallisey

Copy link
Copy Markdown
Contributor

+1

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
Signed-off-by: Andrew Burden <aburden@redhat.com>
Comment thread GOVERNANCE.md
Comment thread GOVERNANCE.md Outdated
Comment thread GOVERNANCE.md
@fabiand

fabiand commented Jan 22, 2025

Copy link
Copy Markdown
Member

Thanks for the work on reshaping the governance model.
All of this is going into the right direction!

It's a living document, follow up changes can be suggested and will be reviewed.

/approve

@kubevirt-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabiand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@vladikr

vladikr commented Jan 24, 2025

Copy link
Copy Markdown
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@kubevirt-bot kubevirt-bot merged commit 82d2152 into kubevirt:main Jan 24, 2025
@kubevirt-bot

Copy link
Copy Markdown
Contributor

/remove-label needs-approver-review

@kubevirt-bot kubevirt-bot removed the needs-approver-review Indicates that a PR requires a review from an approver. label Jan 25, 2025
@aburdenthehand aburdenthehand deleted the maintainer-mentorship branch June 4, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document a complete maintainer lifecycle process (including roles, onboarding, offboarding, and emeritus status).

7 participants