-
-
Notifications
You must be signed in to change notification settings - Fork 44
Deprecate Http Message and Mvc Interfaces/Classes #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.21.x
Are you sure you want to change the base?
Deprecate Http Message and Mvc Interfaces/Classes #127
Conversation
Signed-off-by: Joey Smith <[email protected]> Signed-off-by: Joey Smith <[email protected]>
Signed-off-by: Joey Smith <[email protected]> Signed-off-by: Joey Smith <[email protected]>
gsteel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tyrsson - Just a few nitpicks from me 👍
|
Does anyone else have opinions on deprecating the Laminas\Http / MVC related interfaces and base classess here? Paging @laminas/technical-steering-committee for additional review |
Signed-off-by: Joey Smith <[email protected]> Signed-off-by: Joey Smith <[email protected]>
|
I think it can be removed//deprecated everything related to MVC |
|
I feel that there is too much focus on MVC, even though this is only a standard library. Sure, it is used by MVC, but it gives the impression that the dependency is the other way around. |
|
Well, I'm happy to make whatever changes are required once a consensus can be reached or close it. |
|
Please remember that laminas-http also uses the interfaces and the
We should just be aware that it could generate many more questions and work. |
|
In an ideal world I would say all of those packages should depend on PSR-7. |
This is correct but unfortunately, this means a lot of work, and until everything has been changed over, there will be many questions. I just want to point that out. |
|
Well, I'm not trying to create a bunch of "extra" work. Constantly having to explain what is happening can be "a lot of work" as well. So in light of the need for some discussion/planning etc should I set this as a draft and come back to it once a path has been charted and work completed to a point where it's beneficial to make these changes without causing the additional work? My intent with this PR was mainly to prevent code that should be deprecated in the near future from being overlooked similar to the code that should have been removed in laminas-hydrator V4. I fully understand how short handed the project is and completely understand how limited dev hours are. |
|
@tyrsson |
|
I could have sworn I had done that. Anyway, agree 100%. Thanks. |
| namespace Laminas\Stdlib; | ||
|
|
||
| /** | ||
| * @deprecated since 3.21.0 due to the retirement of Laminas MVC. Will be removed in 4.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
laminas-router uses this interface:
namespace Laminas\Router;
use Laminas\Stdlib\RequestInterface as Request;
interface RouteInterface
{
/**
* Match a given request.
*
* @return RouteMatch|null
*/
public function match(Request $request);
// …And laminas-router is one of the router implementation of Mezzio.
Description
In light of laminas-mvc being retired and its related packages set as security only -
This PR deprecates the Interfaces and classes that laminas-mvc depends on that has been replaced by laminas-diactoros and its PSR7 implementation.
Additional deprecations outside of the strictly PSR7 related interfaces/class: