-
Notifications
You must be signed in to change notification settings - Fork 19.3k
fix: agent node file recognition #30177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: agent node file recognition #30177
Conversation
Summary of ChangesHello @yujiosaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Agent node's ability to interact with and utilize files within chatflows. By enabling the Agent node to recognize and process attached files, it aligns its behavior with the existing LLM node, allowing for more versatile and powerful agent-based applications. The changes include both backend logic for file parsing and frontend UI updates to expose these new configuration options to users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds file recognition capabilities to the Agent node, aligning it with the LLM node's functionality. The changes look good overall, introducing vision configuration on both the backend and frontend, and adding corresponding tests.
I have a couple of suggestions:
- In
api/core/workflow/nodes/agent/agent_node.py, there's an opportunity to refactor some duplicated code for handling file segments to improve maintainability. - The new tests in
api/tests/unit_tests/core/workflow/nodes/agent/test_agent_node.pycould be improved by testing the node's method directly rather than re-implementing its logic, which would make them more robust.
Apart from these points, the implementation is solid and the changes are well-structured.
api/tests/unit_tests/core/workflow/nodes/agent/test_agent_node.py
Outdated
Show resolved
Hide resolved
Resolved conflicts by migrating nodes.agent.vision translation key from deleted workflow.ts files to the new workflow.json format with proper translations for each locale.
1192fbf to
f9aaf4f
Compare
… directly Address Gemini Code Assist High Priority review comment: - Refactor tests to call actual _generate_agent_parameters method instead of re-implementing the logic - Move imports to top of file (using fixture pattern to handle circular imports) - Tests now properly instantiate AgentNode, prepare inputs, call the method, and assert the returned dict is correct - Add new test case for for_log parameter behavior - Add new test case for non-query/instruction parameters
Address Gemini Code Assist Medium Priority review comment: - Combine ArrayFileSegment and FileSegment handling logic to reduce code duplication - Use isinstance check with tuple to handle both segment types in a single branch - Extract files list conditionally based on segment type
Important
Fixes #<issue number>.Summary
Fixes #28140
This PR enables the Agent node to recognize attached files in chatflows, aligning its behavior with the LLM node.
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods