Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 31, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30390

here is a user log
log.txt

2025-12-31 14:05:06 2025-12-31 06:05:06.326 DEBUG [Thread-26 (_generate_worker)] [worker_pool.py:129]  - Stopping worker pool: 1 workers
2025-12-31 14:05:16 2025-12-31 06:05:16.333 DEBUG [Thread-26 (_generate_worker)] [execution_limits.py:110]  - Execution completed: 8 steps in 33.43 seconds

we can see here, wait about 10s

14:05:06.326  WorkerPool.stop()
                ├─ worker.stop() → _stop_event.set()
                └─ worker.join(timeout=10.0) # start wait
                    ↓
                    ↓ 
                    ↓ (possible node.run() iteration)
                    ↓
  14:05:16.333  join() # timeout
                ↓
                ↓ print "Execution completed"

so we need check the stop_event is set or not in the iteration

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Dec 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the responsiveness and efficiency of worker pool shutdowns. By introducing an immediate check for stop events within the worker's processing loop, it eliminates a previously identified 10-second delay during termination, ensuring that workers can be stopped promptly and predictably.

Highlights

  • Addressing Worker Shutdown Delay: This pull request resolves a 10-second delay observed during worker pool shutdown. Previously, worker.join() would wait for node.run() iterations to complete, even after a stop event was issued, causing unnecessary delays.
  • Implementing Immediate Stop Event Check: A crucial check for _stop_event.is_set() has been added within the node.run() event iteration in api/core/workflow/graph_engine/worker.py. This ensures that workers immediately cease processing events upon receiving a stop signal, leading to more responsive shutdowns.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies api/core/workflow/graph_engine/worker.py by adding a check within the _execute_node method. Specifically, inside the loop that processes node_events, a condition if self._stop_event.is_set(): break was introduced. This change ensures that if a stop event is set, the worker will immediately cease iterating through the remaining events from the current node's execution and will not add them to the _event_queue.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 31, 2025
QuantumGhost
QuantumGhost previously approved these changes Dec 31, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iteration Node is very slow.

2 participants