Skip to content

[WIP] initial implementation of skipping prefix hash #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wiibaa
Copy link
Contributor

@wiibaa wiibaa commented Mar 9, 2016

As discussed in #25, when storing metrics into a hash, one could prefer to strip the name of the "container" from the metrics name outputting foo.bar to graphite instead of mymetrics.foo.bar
when the event contains a field mymetrics of type Hash

This PR propose to add a boolean config to strip this prefix and help is wanted in finding the best name for it as it is only applicable to hash-fields.

I'm still working on the doc and the spec, but would like feedback for the field name
@jsvd @purbon @jordansissel want to propose something better than skip_prefix_for_metrics_hash ?

@wiibaa wiibaa force-pushed the feature/skip-prefix-for-hash-field branch from ad49389 to e9fe1af Compare March 9, 2016 12:55
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants