Skip to content

Conversation

@robbavey
Copy link
Member

No description provided.

JackDavidson and others added 2 commits December 17, 2018 13:50
Initial PR was calling '.value' on configuration property which does
not exist for a string type
@elasticsearch-bot elasticsearch-bot self-assigned this Dec 19, 2018
Copy link

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robbavey
Copy link
Member Author

@karenzone would you mind also checking the docs here too?

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and LGTM

@elasticsearch-bot
Copy link

Rob Bavey merged this into the following branches!

Branch Commits
master ef92fc7, b82d75c, 76f8861, 4b59488

elasticsearch-bot pushed a commit that referenced this pull request Dec 19, 2018
Initial PR was calling '.value' on configuration property which does
not exist for a string type

Fixes #213
elasticsearch-bot pushed a commit that referenced this pull request Dec 19, 2018
elasticsearch-bot pushed a commit that referenced this pull request Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants