Fix Windows Line Number #401
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasplund
commented
Dec 27, 2022
| set /a tests_total=0 | ||
| set /a tests_success=0 | ||
| set /a tests_fail=0 | ||
| set /a tests_timeout=0 |
There was a problem hiding this comment.
I am unsure what the best replacement is for timeout, so I removed the timout checks for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #389
The lexer was incorrectly peeking at the current character when seeing if a carriage return also has a trailing line feed. Updated to use peek next to correctly skip over the LF.
Also added a script to run unit tests. These tests pass with and without my change, so I wonder if there is a way to verify the exact line information in the error code.