Resolve symlink of the matlab executable when finding install path

[moetayuko]

Fixing mathworks/MATLAB-extension-for-vscode#42

[dklilley]

Thanks for looking into this!

[nothans]

Can you contact me to sign a CLA? Thank you for the PR!

[nothans]

The CLA has been signed. Please evaluate the PR. Thank you for the contribution!

[dklilley]

Hi @moetayuko, I am trying this out but I think this is not behaving as desired. When I try this, I am seeing that line 356 is executed before the fs.realpath callback is executed, resulting in a null return every time.

Is this what you are seeing as well?

[moetayuko]

Hi @moetayuko, I am trying this out but I think this is not behaving as desired. When I try this, I am seeing that line 356 is executed before the fs.realpath callback is executed, resulting in a null return every time.

Is this what you are seeing as well?

Nope, it simply works as expected on my side.

• I didn't manually set matlabInstallPath so that the "else" block on line 338 is entered, then the "try" block.
• I have a symlink /usr/bin/matlab -> /opt/MATLAB/R2023a/bin/matlab where /usr/bin is in $PATH obviously. Before this PR binPath was assigned /usr/bin, but now it's /opt/MATLAB/R2023a/bin which is expected.

[dklilley]

I think this may be working for you somewhat by luck. Since you are using the non-promise version of fs.realpath, I don't believe the await has any effect. If it resolves fast enough, the callback function may be executed before the try is exited, however this is not guaranteed.

[moetayuko]

I think this may be working for you somewhat by luck. Since you are using the non-promise version of fs.realpath, I don't believe the await has any effect. If it resolves fast enough, the callback function may be executed before the try is exited, however this is not guaranteed.

Indeed. You reminded me that async shouldn't be used. Now I switched to the promise version so it should be working.

[dklilley]

Thanks for making that change!

For me, realpath is resolving to /usr/local/MATLAB/R2023b/bin/matlab, which is expected. However, for this to work, I believe that binPath needs to point to /usr/local/MATLAB/R2023b/bin/.

[moetayuko]

Oops, my bad, this revision must be okay...

[dklilley]

Thanks for fixing this issue!