Cross-browser extension article update by rebloor · Pull Request #30228 · mdn/content

rebloor · 2023-11-13T01:48:47Z

Description

This update includes:

removing the note about the content being incomplete, and replacing it with one mentioning Manifest V2 and Manifest V3
note about Chrome's MV3 support for promises.
section about the differences between content script execution contexts
section mentioning differences in background script support.

Related issues and pull requests

Fixes #20779

github-actions · 2023-11-13T01:51:22Z

Preview URLs

/en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension

External URLs (5)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension
Title: Build a cross-browser extension

https://crbug.com/1510416 (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/extensions/migrating/ (1 time) (Note! This may be a new URL 👀)
https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/ (1 time) (Note! This may be a new URL 👀)
https://github.com/mozilla/webextension-polyfill/ (2 times) (Note! This may be a new URL 👀)
https://medium.com/codebuddies/getting-to-know-asynchronous-javascript-callbacks-promises-and-async-await-17e0673281ee (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-12-11 21:32:40)

jpmedley

You write really clean prose. That makes it look like I was only reviewing for Chrome-related stuff, which I was not.

jpmedley · 2023-11-13T19:48:33Z


- _Promises_, the proposed standard for the extensions API used by Firefox and Safari.
- _Callbacks_, used by Chrome, Edge, and Opera.
+> **Note:** As of November 2023, the Chrome documentation notes that "support has been added to most methods, though callbacks are still supported as an alternative. (We will eventually support promises on all appropriate methods.)"


This note may not be needed. I will get you an answer.

Thanks @jpmedley I'll await your update. Has a bit of a knock-on impact into other work too so would be good to know.

Let's drop this note. I have suggested an edit to clarify the callback support, and the "(We will eventually support promises on all appropriate methods.)" remark is unnecessary.

The vast majority of Chrome extension APIs support Promises now.

Dropping this seems right. Chrome's promise work will be done this quarter. The phrase 'all appropriate methods' is right. There are places where callbacks are appropriate and will remain in use.

Co-authored-by: Joe Medley <jmedley@google.com>

Rob--W

Here is a review of the content that has changed. I haven't reviewed the full (existing) article yet (i.e. the part that does not show up in the diff), but will do that once the pending changes have been resolved.

Rob--W · 2023-11-14T13:28:19Z


- _Promises_, the proposed standard for the extensions API used by Firefox and Safari.
- _Callbacks_, used by Chrome, Edge, and Opera.
+> **Note:** As of November 2023, the Chrome documentation notes that "support has been added to most methods, though callbacks are still supported as an alternative. (We will eventually support promises on all appropriate methods.)"


Let's drop this note. I have suggested an edit to clarify the callback support, and the "(We will eventually support promises on all appropriate methods.)" remark is unnecessary.

The vast majority of Chrome extension APIs support Promises now.

Co-authored-by: Rob Wu <rob@robwu.nl>

…r_extension/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

rebloor · 2023-11-16T22:38:38Z

@Rob--W anything outstanding from your POV

jpmedley · 2023-11-17T20:33:30Z

This has a merge conflict. I'm going to be out of the office for the next week, so please request merge from someone else.

Thank you.

Co-authored-by: Rob Wu <rob@robwu.nl>

Rob--W

Good to merge with one change, mainly due to the uncertainty about Chrome 121 having been resolved (copy edit as you see fit).

Co-authored-by: Rob Wu <rob@robwu.nl>

* Cross-browser extension article update * grammar fix * Apply suggestions from review Co-authored-by: Joe Medley <jmedley@google.com> * Apply suggestions from review Co-authored-by: Rob Wu <rob@robwu.nl> * Adding embedded section links * Removed Chrome promise support evolution note * Update files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * async handling update * Further async clarification * Apply suggestions from review Co-authored-by: Rob Wu <rob@robwu.nl> * Feedback re Chrome support Co-authored-by: Rob Wu <rob@robwu.nl> --------- Co-authored-by: Joe Medley <jmedley@google.com> Co-authored-by: Rob Wu <rob@robwu.nl> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Cross-browser extension article update

fabcc97

rebloor added the Content:WebExt WebExtensions docs label Nov 13, 2023

rebloor self-assigned this Nov 13, 2023

rebloor requested a review from a team as a code owner November 13, 2023 01:48

rebloor requested review from jpmedley and removed request for a team November 13, 2023 01:48

grammar fix

0d39f84

jpmedley requested changes Nov 13, 2023

View reviewed changes

rebloor requested a review from Rob--W November 13, 2023 22:21

Apply suggestions from review

9b1c8e2

Co-authored-by: Joe Medley <jmedley@google.com>

Rob--W requested changes Nov 14, 2023

View reviewed changes

Apply suggestions from review

ab5b70c

Co-authored-by: Rob Wu <rob@robwu.nl>

github-actions Bot reviewed Nov 14, 2023

View reviewed changes

Comment thread files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md

rebloor and others added 3 commits November 15, 2023 11:09

Adding embedded section links

c765741

Removed Chrome promise support evolution note

a374d89

Update files/en-us/mozilla/add-ons/webextensions/build_a_cross_browse…

2dca46e

…r_extension/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

jpmedley approved these changes Nov 16, 2023

View reviewed changes

github-actions Bot reviewed Nov 16, 2023

View reviewed changes

Comment thread files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md Outdated

jpmedley and others added 2 commits November 16, 2023 07:10

Update files/en-us/mozilla/add-ons/webextensions/build_a_cross_browse…

cdee52a

…r_extension/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

async handling update

820b725

rebloor added 2 commits November 17, 2023 11:38

Merge branch 'main' into cross-browser-article-update

cdf5d7a

Further async clarification

0c74036

jpmedley approved these changes Nov 17, 2023

View reviewed changes

Rob--W reviewed Nov 17, 2023

View reviewed changes

Comment thread files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md Outdated

Comment thread files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md Outdated

Apply suggestions from review

44ca2cb

Co-authored-by: Rob Wu <rob@robwu.nl>

rebloor requested a review from Rob--W November 20, 2023 01:13

Merge branch 'main' into cross-browser-article-update

8e8775f

Merge branch 'main' into cross-browser-article-update

da1cfd6

Rob--W approved these changes Dec 11, 2023

View reviewed changes

Comment thread files/en-us/mozilla/add-ons/webextensions/build_a_cross_browser_extension/index.md Outdated

rebloor and others added 2 commits December 12, 2023 10:28

Feedback re Chrome support

7257cd8

Co-authored-by: Rob Wu <rob@robwu.nl>

Merge branch 'main' into cross-browser-article-update

a541937

rebloor merged commit a1a5869 into mdn:main Dec 11, 2023

rebloor deleted the cross-browser-article-update branch December 11, 2023 21:37

Conversation

rebloor commented Nov 13, 2023

Description

Related issues and pull requests

Uh oh!

github-actions Bot commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpmedley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jpmedley Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

rebloor Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

Rob--W Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

jpmedley Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rob--W left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Rob--W Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rebloor commented Nov 16, 2023

Uh oh!

jpmedley commented Nov 17, 2023

Uh oh!

Uh oh!

Uh oh!

Rob--W left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Nov 13, 2023 •

edited

Loading