-
Notifications
You must be signed in to change notification settings - Fork 139
Mac OS X brew download/install instructions #2597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Requires Homebrew/homebrew-core#223155 to be merged first. |
ba5959d
to
49175cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I left some annoying nits.
| Linux | [mender-cli 1.12.0][x.x.x_mender-cli-linux] | [mender-cli master][master_mender-cli-linux] (Pre-release) | | ||
| Mac OS X | [mender-cli 1.12.0][x.x.x_mender-cli-darwin] | [mender-cli master][master_mender-cli-darwin] (Pre-release) | | ||
|
||
| Latest release | Pre-release | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about the naming of columns, someone should verify that -- I have no idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch: as we move away from binaries to packages, we won't offer here anymore a "pre-release" version (iow master) for the tool.
We can remove now or remove after having the mender-cli Linux (Debian/Ubuntu) packages in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove after having the mender-cli Linux (Debian/Ubuntu) packages in place
I'd leave it to that batch of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we remove all such download tables now that we're using the repos.
I think that Mender Docs' owner @estenberg should look into this one 👀 |
49175cf
to
f0dc863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See how much easier it is with repos :) No chmod, no click and download right platform tool, no path modification, etc.
Main thing is I think we should simply remove all these download tables. I think installing individual packages is not the way to go if we have repos. Offering alternatives puts more mental burden on users.
|
||
!!! * For Debian and Ubuntu, you can also install `mender-artifact` through the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we remove the above table to packages, and change this package repo way to be the only way to install mender-artifact.
| Linux | [mender-cli 1.12.0][x.x.x_mender-cli-linux] | [mender-cli master][master_mender-cli-linux] (Pre-release) | | ||
| Mac OS X | [mender-cli 1.12.0][x.x.x_mender-cli-darwin] | [mender-cli master][master_mender-cli-darwin] (Pre-release) | | ||
|
||
| Latest release | Pre-release | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we remove all such download tables now that we're using the repos.
Yes, of course. And we can ship man pages, bash completion and whatnot. Definitely the way to go.
I agree. And I wish we could do it. But right now, we don't have So I don't think pointing users to repositories even more than before is a smart move right now. However, we can already provide |
Split the instructions for `mender-artifact` installation into Debian/Ubuntu and Mac OS X sections and instruct the Mac OS X users to use `brew install mender-artifact` instead of pre-built binaries. Ticket: MEN-8333 Changelog: none Signed-off-by: Vratislav Podzimek <[email protected]>
Split the instructions for `mender-cli` installation into GNU/Linux and Mac OS X sections and instruct the Mac OS X users to use `brew install mender-cli` instead of pre-built binaries. Ticket: MEN-8333 Changelog: none Signed-off-by: Vratislav Podzimek <[email protected]>
Instead of a link to the `mender-cli` binary, we can tell users to follow the mender-cli installation instructions from the Downloads page which is more comprehensive. Also adjust the commands to `mender-cli` being available in `$PATH` after a proper installation. Ticket: MEN-8333 Changelog: none Signed-off-by: Vratislav Podzimek <[email protected]>
Step 1 should be h2, just like Prerequisites and other steps. Ticket: none Changelog: none Signed-off-by: Vratislav Podzimek <[email protected]>
f0dc863
to
396b920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpodzime makes sense, it's too early to remove the download tables then. We'll get them soon :)
Plus one small related change.