Async: update test app #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note, when reviewing, the local tests currently failed at my machine with the following output: [object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:80:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:80:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:81:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:81:8
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:82:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:82:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:83:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:83:8
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:84:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:84:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:85:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:85:8
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:86:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:86:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:87:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:87:8
(node:3918) UnhandledPromiseRejectionWarning: TypeError: Spacebars.call(...).catch is not a function
at packages/local-test_spacebars.js:88:84
(Use `node --trace-warnings ...` to show where the warning was created)
(node:3918) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:3918) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:94:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:94:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:95:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:95:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:96:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:96:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:97:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:97:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:98:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:98:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:99:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.ok (packages/tinytest/tinytest.js:26:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:150:12)
at packages/local-test_spacebars.js:99:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:100:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:100:8
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
Trying to report a test not in a fiber! You probably forgot to wrap a callback in bindEnvironment.
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:101:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:101:8
[object Object]
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:424:21)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:102:8
[object Object]
at TestRun.onReport (packages/tinytest/tinytest_server.js:64:17)
at TestRun._report (packages/tinytest/tinytest.js:659:10)
at test.run.totalTime (packages/tinytest/tinytest.js:539:12)
at TestCaseResults.onEvent (packages/tinytest/tinytest.js:426:18)
at TestCaseResults.fail (packages/tinytest/tinytest.js:80:10)
at TestCaseResults.equal (packages/tinytest/tinytest.js:147:12)
at packages/local-test_spacebars.js:102:8The failed tests were: waiting...
S: Spacebars.call
waiting...
S: Spacebars.dot
waiting...
C: Spacebars.call
waiting...
C: Spacebars.dot |
StorytellerCZ
approved these changes
May 23, 2023
Collaborator
StorytellerCZ
left a comment
There was a problem hiding this comment.
We should probably update other dependencies as well.
Contributor
|
How are you running locally? it has differences if you are using the meteor from the checkout or your global meteor (I discovered this in the worst way 😢 )
I'm afraid that this will take some time. But if everyone is onboard we can do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
test-appto Meteor 2.12 and each tracker dependency to 1.3.0. The previoustest-appwas set at Meteor 2.7.1 with Tracker at 1.2.0, causing a version conflict for Tracker.