-
Notifications
You must be signed in to change notification settings - Fork 123
Try Fix Launching with non-Ascii characters in path to Language Server #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per report in #687, try to fix proper handling of non-ascii characters in path to server modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates how the Language Server DLL path is constructed to support non-ASCII characters, adjusts packaging scripts, and renames a source file entry for consistency.
- Use
vscode.Uri.joinPathandfsPathfor server module path to handle Unicode paths - Add a
compilestep to packaging scripts and remove unused@vscode/vscedependency - Rename
devskimFixer.tsreference todevSkimFixer.tsintsconfig.json
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated main field, added compile in pack scripts, removed VSCE |
| client/tsconfig.json | Renamed devskimFixer.ts to devSkimFixer.ts |
| client/extension.ts | Switched to vscode.Uri.joinPath and used fsPath for DLL lookup |
Comments suppressed due to low confidence (3)
DevSkim-VSCode-Plugin/client/tsconfig.json:24
- The filename was changed to
devSkimFixer.ts; please ensure the actual file on disk and all import references use the exact same casing to avoid module resolution errors on case-sensitive file systems.
"devSkimFixer.ts",
DevSkim-VSCode-Plugin/package.json:308
- The
compilescript is not defined in this package.json, so runningnpm run pack-extwill fail. Consider referencing the existingesbuildscript or add acompilescript to build the extension.
"pack-ext": "npm run pre-pack-clean && npm run setup:release && npm run compile && npm run set-version-and-pack",
DevSkim-VSCode-Plugin/package.json:309
- The
compilescript is missing here as well, which will break the debug packaging flow. Update this to use an existing build script or definecompile.
"pack-ext:debug": "npm run pre-pack-clean && npm run setup && npm run compile && npm run set-version-and-pack",
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Change mechanism to construct path to server module to support broader array of character sets. Manually validated by hardcoding a path that included a non-ascii char like reported in #687 to launch server modules from. Some minor clean up work included as well.