Skip to content

Conversation

@gfs
Copy link
Contributor

@gfs gfs commented May 28, 2025

Change mechanism to construct path to server module to support broader array of character sets. Manually validated by hardcoding a path that included a non-ascii char like reported in #687 to launch server modules from. Some minor clean up work included as well.

gfs added 4 commits May 28, 2025 10:20
Per report in #687, try to fix proper handling of non-ascii characters in path to server modules
@gfs gfs requested a review from Copilot May 28, 2025 17:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates how the Language Server DLL path is constructed to support non-ASCII characters, adjusts packaging scripts, and renames a source file entry for consistency.

  • Use vscode.Uri.joinPath and fsPath for server module path to handle Unicode paths
  • Add a compile step to packaging scripts and remove unused @vscode/vsce dependency
  • Rename devskimFixer.ts reference to devSkimFixer.ts in tsconfig.json

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updated main field, added compile in pack scripts, removed VSCE
client/tsconfig.json Renamed devskimFixer.ts to devSkimFixer.ts
client/extension.ts Switched to vscode.Uri.joinPath and used fsPath for DLL lookup
Comments suppressed due to low confidence (3)

DevSkim-VSCode-Plugin/client/tsconfig.json:24

  • The filename was changed to devSkimFixer.ts; please ensure the actual file on disk and all import references use the exact same casing to avoid module resolution errors on case-sensitive file systems.
"devSkimFixer.ts",

DevSkim-VSCode-Plugin/package.json:308

  • The compile script is not defined in this package.json, so running npm run pack-ext will fail. Consider referencing the existing esbuild script or add a compile script to build the extension.
"pack-ext": "npm run pre-pack-clean && npm run setup:release && npm run compile && npm run set-version-and-pack",

DevSkim-VSCode-Plugin/package.json:309

  • The compile script is missing here as well, which will break the debug packaging flow. Update this to use an existing build script or define compile.
"pack-ext:debug": "npm run pre-pack-clean && npm run setup && npm run compile && npm run set-version-and-pack",

@gfs
Copy link
Contributor Author

gfs commented May 28, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@gfs gfs merged commit 963f0f6 into main May 29, 2025
16 checks passed
@gfs gfs deleted the gfs/#687 branch May 29, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants