Skip to content

importModuleSpecifierEnding changes .ts string completions to .js #44602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 21, 2021
Merged

importModuleSpecifierEnding changes .ts string completions to .js #44602

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc80712
don't add .ts extensions to imports
jessetrinity Jun 15, 2021
76509c3
Update src/services/stringCompletions.ts
Jun 15, 2021
25555c3
add other supported extension types
jessetrinity Jun 21, 2021
ab950c0
add final newlines
jessetrinity Jun 21, 2021
5adaabc
adress PR comment
jessetrinity Jun 21, 2021
15a4735
add unsupported extension test
jessetrinity Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add unsupported extension test
  • Loading branch information
@jessetrinity
jessetrinity committed Jun 21, 2021
commit 15a473539ee7657e83dc654537165816c5df17f8
9 changes: 9 additions & 0 deletions tests/cases/fourslash/completionImportModuleSpecifierEndingUnsupportedExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/// <reference path='fourslash.ts'/>
//@Filename:index.css
//// body {}

//@Filename:module.ts
////import ".//**/"

verify.completions({ marker: "", excludes:"index.css", preferences: {importModuleSpecifierEnding: "js" }, isNewIdentifierLocation: true});
verify.completions({ marker: "", excludes:"index", preferences: {importModuleSpecifierEnding: "index" }, isNewIdentifierLocation: true});