Pass RESP3 to modules and custom commands #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e> directly. This lets these functions be aware of current protocol and provides a wide range of output functions.
prvyk
commented
May 20, 2025
badrishc
reviewed
May 20, 2025
…pable as previous direct access to IMemoryOwner.
badrishc
approved these changes
May 22, 2025
TedHartMS
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes command and module signatures so that we pass RespMemoryWriter to them instead of the ref tuple. This allows adjusting output to RESP3.
I considered the alternative of just passing an additional respProtocolVersion in the signature, and I think this is slightly nicer. We can erase some custom output code, authors get more output functions, and reallocation is handled for them. If they want the previous allocation behaviour (measure and then Rent exactly from the pool), they can get it by calling RespMemoryWriter.Realloc() themselves first.