Update BDN config values for JSON.Operations #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates performance threshold values in the BDN benchmark config for JSON operations to account for higher Net90 timings on Ubuntu, ensuring Ubuntu benchmarks no longer falsely fail.
- Bumped expected timings for all JSON operations (GetCommand, SetCommand, DeepPath, ArrayPath, FilterPath, Recursive) across ACL, AOF, and None modes.
- Aligned “ArrayElementsPath” values remain unchanged.
- Adjusted values reflect Ubuntu-specific performance characteristics.
Comments suppressed due to low confidence (1)
test/BDNPerfTests/BDN_Benchmark_Config.json:362
- [nitpick] This JSON config repeats large numeric thresholds across ACL, AOF, and None sections. Consider extracting common values or generating this file programmatically to reduce duplication and simplify future updates.
"expected_ModuleJsonGetCommand_ACL": 330000,
badrishc
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BDN config values needed to be updated due to the inconsistencies of Net90 on Ubuntu. It was a significant bump on most as they Net90 Ubuntu "could" be higher than the others.