osversion: Add new versions, fix compat bug, improve tests #2327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ef83b2 to
02d6305
Compare
katiewasnothere
approved these changes
Nov 25, 2024
As of recent Go versions, specifying the go directive without a patch (e.g. 1.22) is no longer supported. Because go tries to download a matching toolchain if you're not already using one, it will try to download go toolchain version 1.22, which doesn't exist (1.22.0 does). Fix the go.mod version to specify the full version with patch, 1.22.0. Signed-off-by: Kevin Parsons <[email protected]>
- Add V23H2 (annual channel) and LTSC2025 to the version list - Use the LTSC build naming in the compat checks and tests, to make intent clearer - Fix a bug in the compat check. A given LTSC release should be able to run everything from the previous LTSC up to itself - Add new test cases, including for the fixed compat check bug - Change the tests to use t.Run for each test case Signed-off-by: Kevin Parsons <[email protected]>
02d6305 to
bacda39
Compare
kiashok
reviewed
Dec 17, 2024
kiashok
reviewed
Dec 17, 2024
kiashok
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intent clearer
run everything from the previous LTSC up to itself
Signed-off-by: Kevin Parsons [email protected]