(fix/feat) Traktor Kontrol S4 Mk3: tempo offset per deck #14882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
commented
May 31, 2025
Comment on lines
+1658
to
+1667
| if (receivingFirstValue) { | ||
| // Initialize center range incl. offset | ||
| if (this.deck === TraktorS4MK3.leftDeck) { | ||
| this.tempoCenterLower = TempoCenterLowerL; | ||
| this.tempoCenterUpper = TempoCenterUpperL; | ||
| } else { | ||
| this.tempoCenterLower = TempoCenterLowerR; | ||
| this.tempoCenterUpper = TempoCenterUpperR; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a hack because I didn't manage to access TraktorS4MK3 in the ctor list above.
How would I implement this @acolombier ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st is a fixup for #14721 (tempo center offset was missing factor ticks/mm)
2nd allows to set the offset per side