Add unlink_traces_from_run batch operation
#18316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements batch unlinking of traces from runs, complementing the existing `link_traces_to_run` functionality added in mlflow#18295. Changes: - Add `unlink_traces_from_run` to `AbstractStore` with default NotImplementedError - Implement `unlink_traces_from_run` in `DatabricksRestStore` with V4 batch API support - Add `_group_traces_by_location` helper to reduce code duplication - Add `unlink_traces_from_run` method to `MlflowClient` - Add comprehensive tests for V4 traces, V3 error handling, and multi-location grouping 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: harupy <[email protected]>
Member
Author
|
/review |
Signed-off-by: harupy <[email protected]>
harupy
commented
Oct 15, 2025
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Contributor
|
Documentation preview for 952de66 is available at:
More info
|
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
…ogic Signed-off-by: harupy <[email protected]>
Member
Author
|
/review |
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
serena-ruan
reviewed
Oct 15, 2025
serena-ruan
reviewed
Oct 15, 2025
serena-ruan
approved these changes
Oct 15, 2025
Collaborator
serena-ruan
left a comment
There was a problem hiding this comment.
LGTM! Left some nits :)
- Simplify _group_traces_by_location by reusing the same variable name for trace_id instead of having separate otel_trace_id variable - Update error message to avoid mentioning V3/V4 terminology, instead focusing on UC schema location requirement - Update test assertions to match the new error message 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: harupy <[email protected]>
serena-ruan
pushed a commit
to serena-ruan/mlflow
that referenced
this pull request
Oct 16, 2025
Signed-off-by: harupy <[email protected]> Co-authored-by: Claude <[email protected]>
serena-ruan
pushed a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: harupy <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Follows up on #18295 which added
link_traces_to_run.What changes are proposed in this pull request?
Adds
unlink_traces_from_run()batch operation toMlflowClientandDatabricksRestStorefor unlinking traces from runs (V4 traces only).How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Added
unlink_traces_from_run()method toMlflowClientfor batch unlinking traces from runs.What component(s), interfaces, languages, and integrations does this PR affect?
area/tracking: Tracking Service, tracking client APIs, autologgingarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityHow should the PR be classified in the release notes? Choose one:
rn/feature- A new user-facing feature worth mentioning in the release notesShould this PR be included in the next patch release?
🤖 Generated with Claude Code