Add option to ask which container a page should be open in when it has no site assigned to it#2530
Open
bradsharp wants to merge 1 commit into
Open
Add option to ask which container a page should be open in when it has no site assigned to it#2530bradsharp wants to merge 1 commit into
bradsharp wants to merge 1 commit into
Conversation
|
Would this possibly fulfill the AC required to satisfy #2535 ? I've been keeping an eye on this issue for months and it feels like if I was asked to select a container for every tab that is not currently assigned to be auto-opened in a container, then the Ctrl-T new tab behavior would work as expected. |
|
Would it be possible to have manual rules, as it described here: #2134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the select page which prompts the user to select the container they want to use when they open a site without a container already assigned to it. This encourages users to separate out their websites into containers if they wish, a common feature that I want myself and have also seen others ask for.
By default this setting is disabled but it can be enabled by the user if they go into the options menu.
An example of what the select page looks like with default containers:
I am not familiar with the localization process but I have edited the json files in the locales submodule. I would appreciate it if someone could explain to me what the intended way to include those is.