Fix page load for proxied containers when Mozilla VPN isn't active (fix #2570)#2645
Open
lusimeon wants to merge 1 commit into
Open
Fix page load for proxied containers when Mozilla VPN isn't active (fix #2570)#2645lusimeon wants to merge 1 commit into
lusimeon wants to merge 1 commit into
Conversation
Remove the use of the proxy if Mozilla VPN inactive, still load page in the dedicated container fix mozilla#2570
|
The proposed solution might be dangerous? Could cause involuntary VPN leak. A specific error page explaining the situation and why the request was blocked (perhaps with a button to pass through anyway - similar to the flow for invalid TLS certs?) seems more on-point (albeit a more involved implementation)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
Remove the use of the proxy if Mozilla VPN inactive, still load page in the dedicated container. Without this fix, infinite page load happen on custom location proxied containers if Mozilla VPN is inactive (more info on #2570).
To reproduce:
Type of change
Tag issues related to this pull request: