Skip to content

Improve Rust build script #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mratsim merged 1 commit into from
Dec 28, 2024
Merged

Improve Rust build script #500

mratsim merged 1 commit into from
Dec 28, 2024

Conversation

@DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Dec 26, 2024 •
edited
Loading

  • Report nimble build errors
    • I encountered a few build errors due to missing llvm-as, which was not reported on the console.
  • Improve rustc-link-lib directive by letting the compiler find the correct target-specific name
    • I believe this should work, will revert if CI fails
  • Reduce rerun-if-changed directives to reduce unnecessary re-compilations
    • Currently every single cargo build rebuilds constantine which takes like 15s.

@DaniPopes
Improve Rust build script
8b9c2da 
- Report `nimble` build errors
- Improve rustc-link-lib directive by letting the compiler find the correct
  target-specific name
- Reduce rerun-if-changed directives to reduce unnecessary re-compilations
@mratsim
Copy link
Owner

mratsim commented Dec 28, 2024

Thank you!

@mratsim mratsim merged commit b79c0d0 into mratsim:master Dec 28, 2024
@DaniPopes DaniPopes deleted the rust-build branch December 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaniPopes @mratsim