Skip to content

Bugfix: mysql-connector-cpp cmake files not work well when as a third party #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

louishust
Copy link

@louishust louishust commented Oct 9, 2019

When using mysql-connector-cpp as a third-party code in project like below:

project(XDEV-DEMO)

cmake_minimum_required(VERSION 3.0.2)

add_subdirectory(third_party/mysql-connector-cpp)
include_directories(third_party/mysql-connector-cpp/include)

add_executable(demo demo.cc)
target_link_libraries(demo connector)

mysql-connector-cpp will not compile correctly when as a submodule project.

@louishust louishust changed the title Bugfix: mysql-connector-cpp cmake files not work well when as a third… Bugfix: mysql-connector-cpp cmake files not work well when as a third party Oct 9, 2019
@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@louishust
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@louishust
Copy link
Author

@mysql-oca-bot I already mailed OCA yesterday, plz check it.

@mysql-admin
Copy link

@louishust It can take a few days ntil the contribution is entered into the system. Once done the contribution will be taken

Thanks for your contribution
==Omer

@mysql-oca-bot
Copy link

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed.
Thanks

@rsomla1
Copy link
Contributor

rsomla1 commented Oct 16, 2024

Note: as of version 9.0+ this should be no longer an issue (the relevant cmake scripts have changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants