Bugfix: Macro INTERNAL conflict with gRPC header status contant defin… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. In grpc/include/grpcpp/impl/codegen/status_code_enum.h , enum StatusCode 117- /// Internal errors. Means some invariants expected by underlying System has 118- /// been broken. If you see one of these errors, Something is very broken. 119: INTERNAL = 13, Replace Macro INTERNAL with INTERNAL_API will solve this conflict.
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
|
Hi, Sadly, I can not use your patch if you have not signed the OCA agreement. Please sign it if possible. Since you described the issue clearly I will go ahead and report a bug for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Macro INTERNAL will result in conflict with google gRPC status code defintion.
reference: https://github.com/grpc/grpc/blob/master/include/grpcpp/impl/codegen/status_code_enum.h
In grpc/include/grpcpp/impl/codegen/status_code_enum.h , enum StatusCode
117- /// Internal errors. Means some invariants expected by underlying System has
118- /// been broken. If you see one of these errors, Something is very broken.
119: INTERNAL = 13,
Replace Macro INTERNAL with INTERNAL_API will solve this conflict.