Skip to content

Define copy/move functions to make Db_obj_base and its derived classes nothrow movable #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Mibu287
Copy link

@Mibu287 Mibu287 commented Sep 4, 2021

class mysqlx::internal::Db_obj_base has only destructor defined => its move constructor/assignment is implicitly deleted. Therefore, if its derived classes (mysql::Schema) is used in container like std::vector, the container can not invoke move constructor when resizing.
Fixed by defining defaulted copy/move functions (Rule of 5).

@Mibu287 Mibu287 marked this pull request as ready for review September 4, 2021 11:42
@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@mysql-oca-bot
Copy link

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants