Skip to content

Fix windows compilation issue in cmake/libutils/save_linker_opts.cc #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lpinto-es
Copy link
Contributor

Fixed a compilation issue in Windows where "unistd.h" was still being used to call "getcwd".
Protected the "unistd.h" with a #ifdef WIN32 macro and added a windows alternative using the #include <direct.h> and the _getcwd counterpart for that OS.

I was getting this issue while compiling with Ninja, and after those changes everything now compiles as it should (against openssl 1.1.1q using VS 2019 (latest update) on a Windows 11 intel machine!)

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@lpinto-es
Copy link
Contributor Author

Already signed the Oracle Contribution Agreement (OCA)

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@lpinto-es
Copy link
Contributor Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=108355 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants