Skip to content

Fix Windows static build #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Xiaobin0860
Copy link

No description provided.

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@Xiaobin0860
Copy link
Author

Already signed the Oracle Contribution Agreement (OCA)

@mysql-oca-bot
Copy link

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed.
Thanks

@mwl4
Copy link

mwl4 commented Sep 12, 2023

This MR should be merged, as still master does not build on MSVC with following cmake options:

-DBUILD_STATIC=true -DSTATIC_MSVCRT=true

Author of MR has responded that OCA has been signed. What is problem with merging it then?

@rsomla1
Copy link
Contributor

rsomla1 commented Sep 13, 2023

Hi,

The problem is that our system thought the OCA is not signed and closed the request. I am trying to find out what has happened.

@mysql-admin
Copy link

Hi @Xiaobin086,
We can't find an OCA from you in our system. Possibly your OCA is not linked correctly to your name, or github handle.
Please email [email protected] with details

Thanks for contributing to MySQL
==Omer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants