-
Notifications
You must be signed in to change notification settings - Fork 257
Clear the return variable from the CMake cache #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
@@ -880,6 +880,7 @@ function(find_imp_lib var base_name path) | |||
set(CMAKE_FIND_LIBRARY_SUFFIXES .lib) | |||
|
|||
#message("!!! Looking for import library for: ${path}") | |||
unset(${var} CACHE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the problem this is fixing?
When I used this cmake file to import the JDBC library, the actual linked file in the final generated vcxproj file was mysqlcppconnx.lib, not mysqlcppconn.lib. This was because the function was called twice to obtain the file paths of the two libraries, resulting in the second direct read of the cmake cache and ultimately causing an error.
原始邮件
发件人:Rafal Somla ***@***.***>
发件时间:2025年3月20日 23:23
收件人:mysql/mysql-connector-cpp ***@***.***>
抄送:TimeLooper ***@***.***>, Author ***@***.***>
主题:Re: [mysql/mysql-connector-cpp] Clear the return variable from theCMake cache (PR #37)
@rsomla1 commented on this pull request.
In mysql-concpp-config.cmake.in:
> @@ -880,6 +880,7 @@ function(find_imp_lib var base_name path) set(CMAKE_FIND_LIBRARY_SUFFIXES .lib) #message("!!! Looking for import library for: ${path}") + unset(${var} CACHE)
What is the problem this is fixing?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Right. I asked because the
However, I checked that |
No description provided.