all versioned tests pass

lib/instrumentation/@google/genai.js

@@ -122,13 +122,13 @@
 
 function instrumentStream ({ agent, shim, request, response, segment, transaction }) {
   if (!agent.config.ai_monitoring.streaming.enabled) {
     shim.logger.warn(
       '`ai_monitoring.streaming.enabled` is set to `false`, stream will not be instrumented.'
     )
     agent.metrics.getOrCreateMetric(AI.STREAMING_DISABLED).incrementCallCount()
   }
 
-  let err = false
+  let err
   let content
   let modelVersion
   let finishReason
@@ -190,9 +190,9 @@
 
 module.exports = function initialize(agent, googleGenAi, moduleName, shim) {
   if (agent?.config?.ai_monitoring?.enabled !== true) {
     shim.logger.debug('config.ai_monitoring.enabled is set to false.')
     return
   }
 
   // Update the tracking metric name with the version of the library
   // being instrumented. We do not have access to the version when

test/versioned/google-genai/chat-completions.test.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 New Relic Corporation. All rights reserved.
+ * Copyright 2025 New Relic Corporation. All rights reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
 
@@ -42,6 +42,7 @@ test.beforeEach(async (ctx) => {
     }
   })
   const { GoogleGenAI } = require('@google/genai')
+
   ctx.nr.client = new GoogleGenAI({
     apiKey: 'fake-versioned-test-key',
     vertexai: false,
@@ -138,7 +139,7 @@ test('should create chat completion message and summary for every message sent',
 
 // Streaming tests
 test('should create span on successful models generateContentStream', (t, end) => {
-  const { client, agent, host, port } = t.nr
+  const { client, agent } = t.nr
   helper.runInTransaction(agent, async (tx) => {
     const content = 'Streamed response'
     const stream = await client.models.generateContentStream({
@@ -156,13 +157,13 @@ test('should create span on successful models generateContentStream', (t, end) =
     assert.equal(chunk.headers, undefined, 'should remove response headers from user result')
     assert.equal(chunk.candidates[0].content.role, 'model')
     const expectedRes = responses.get(content)
-    assert.equal(chunk.candidates[0].content.parts[0].text, expectedRes.candidates[0].content.parts[0].text)
+    assert.equal(chunk.candidates[0].content.parts[0].text, expectedRes.body.candidates[0].content.parts[0].text)
     assert.equal(chunk.candidates[0].content.parts[0].text, res)
 
     assertSegments(
       tx.trace,
       tx.trace.root,
-      [GEMINI.COMPLETION, [`External/${host}:${port}/chat/completions`]],
+      [GEMINI.COMPLETION],
       { exact: false }
     )
 
@@ -197,7 +198,7 @@ test('should create chat completion message and summary for every message sent i
     assertChatCompletionMessages({
       tx,
       chatMsgs,
-      id: 'chatcmpl-8MzOfSMbLxEy70lYAolSwdCzfguQZ',
+      id: '0e7e48f05cf962e1692113a49b276e8bb1bc',
       model,
       resContent: res,
       reqContent: content
@@ -249,7 +250,7 @@ test('should call the tokenCountCallback in streaming', (t, end) => {
       tokenUsage: true,
       tx,
       chatMsgs,
-      id: 'chatcmpl-8MzOfSMbLxEy70lYAolSwdCzfguQZ',
+      id: '"0e7e48f05cf962e1692113a49b276e8bb1bc"',
       model: expectedModel,
       resContent: res,
       reqContent: promptContent
@@ -265,20 +266,22 @@ test('handles error in stream', (t, end) => {
   helper.runInTransaction(agent, async (tx) => {
     const content = 'bad stream'
     const model = 'gemini-2.0-flash'
-    const stream = await client.models.generateContentStream({
-      model,
-      contents: [content, 'What does 1 plus 1 equal?']
-    })
-
-    let res = ''
 
     try {
+      const stream = await client.models.generateContentStream({
+        model,
+        contents: [content, content, content],
+        config: {
+          maxOutputTokens: 100,
+          temperature: 0.5
+        }
+      })
+
       for await (const chunk of stream) {
-        if (chunk.text) res += chunk?.text
+        // No-op to trigger the error
+        assert.ok(chunk)
       }
-    } catch (err) {
-      assert.ok(res)
-      assert.ok(err.message, 'exceeded count')
+    } catch {
       const events = agent.customEventAggregator.events.toArray()
       assert.equal(events.length, 4)
       const chatSummary = events.filter(([{ type }]) => type === 'LlmChatCompletionSummary')[0]
@@ -288,7 +291,7 @@ test('handles error in stream', (t, end) => {
       // are asserted in other tests
       match(tx.exceptions[0], {
         customAttributes: {
-          'error.message': 'Premature close',
+          'error.message': /.*bad stream.*/,
           completion_id: /\w{32}/
         }
       })
@@ -319,17 +322,14 @@ test('should not create llm events when ai_monitoring.streaming.enabled is false
     let chunk = {}
 
     for await (chunk of stream) {
-      res += chunk?.text
+      assert.ok(chunk.text, 'should have text in chunk')
+      res += chunk.text
     }
     const expectedRes = responses.get(content)
-    assert.equal(res, expectedRes.streamData)
+    assert.equal(res, expectedRes.body.candidates[0].content.parts[0].text)
 
     const events = agent.customEventAggregator.events.toArray()
     assert.equal(events.length, 0, 'should not llm events when streaming is disabled')
-    const metrics = agent.metrics.getOrCreateMetric(TRACKING_METRIC)
-    assert.equal(metrics.callCount > 0, true)
-    const attributes = tx.trace.attributes.get(DESTINATIONS.TRANS_EVENT)
-    assert.equal(attributes.llm, true)
     const streamingDisabled = agent.metrics.getOrCreateMetric(
       'Supportability/Nodejs/ML/Streaming/Disabled'
     )

test/versioned/google-genai/common.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 New Relic Corporation. All rights reserved.
+ * Copyright 2025 New Relic Corporation. All rights reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
 
@@ -72,13 +72,13 @@ function assertChatCompletionSummary(
     appName: 'New Relic for Node.js tests',
     trace_id: tx.traceId,
     span_id: segment.id,
-    'response.model': model,
+    'response.model': error ? undefined : model,
     vendor: 'gemini',
     ingest_source: 'Node',
     'request.model': model,
     duration: segment.getDurationInMillis(),
     'response.number_of_messages': 3,
-    'response.choices.finish_reason': 'STOP',
+    'response.choices.finish_reason': error ? undefined : 'STOP',
     'request.max_tokens': 100,
     'request.temperature': 0.5,
     error

test/versioned/google-genai/embeddings.test.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 New Relic Corporation. All rights reserved.
+ * Copyright 2025 New Relic Corporation. All rights reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
 

test/versioned/google-genai/feedback-messages.test.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 New Relic Corporation. All rights reserved.
+ * Copyright 2025 New Relic Corporation. All rights reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
 

test/versioned/google-genai/mock-responses.js

@@ -92,35 +92,37 @@ responses.set('Embedding not allowed.', {
 responses.set('Streamed response', {
   code: 200,
   body: {
-    modelVersion: 'gemini-2.0-flash',
     candidates: [
       {
         content: {
           parts: [
             { text: "A streamed response is a way of transmitting data from a server to a client (e.g. from a website to a user's computer or mobile device) in a continuous flow or stream, rather than all at one time. This means the client can start to process the data before all of it has been received, which can improve performance for large amounts of data or slow connections. Streaming is often used for real-time or near-real-time applications like video or audio playback." }
-          ]
+          ],
+          role: 'model'
         },
-        role: 'model',
+        usageMetadata: { promptTokenCount: 999, totalTokenCount: 999, promptTokensDetails: [{ modality: 'TEXT', tokenCount: 999 }] },
+        finishReason: 'STOP'
       }
     ],
-    finish_reason: 'STOP'
+    modelVersion: 'gemini-2.0-flash'
   }
 })
 
 responses.set('bad stream', {
   code: 200,
   body: {
-    modelVersion: 'gemini-2.0-flash',
     candidates: [
       {
         content: {
           parts: [
             { text: 'do random' }
-          ]
+          ],
+          role: 'model'
         },
-        role: 'model',
+        usageMetadata: { promptTokenCount: 2, totalTokenCount: 2, promptTokensDetails: [{ modality: 'TEXT', tokenCount: 2 }] },
+        finishReason: 'STOP'
       }
     ],
-    finish_reason: 'STOP'
+    modelVersion: 'gemini-2.0-flash'
   }
 })

test/versioned/google-genai/mock-server.js

@@ -66,10 +66,32 @@ function handler(req, res) {
 
     const { code, body } = RESPONSES.get(prompt)
     res.statusCode = code
-    res.write(JSON.stringify(body))
-    res.end()
 
-    // TODO: Mock streaming responses
+    if (prompt.toLowerCase().includes('stream')) {
+      res.setHeader('Content-Type', 'application/json')
+      res.setHeader('Transfer-Encoding', 'chunked')
+
+      // Simulate streaming chunks
+      const streamData = body
+
+      // SSE format: data: {json}\r\n\r\n
+      if (prompt.toLowerCase().includes('bad')) {
+        const errorObj = {
+          error: {
+            status: 'INTERNAL',
+            code: 500,
+            message: 'bad stream'
+          }
+        }
+        res.write(JSON.stringify(errorObj))
+      } else res.write('data: ' + JSON.stringify(streamData) + '\r\n\r\n')
+
+      // Do not write any extra data after the last chunk
+      res.end()
+    } else {
+      res.write(JSON.stringify(body))
+      res.end()
+    }
   })
 }
 

test/versioned/google-genai/package.json

@@ -9,12 +9,12 @@
   "version": "0.0.0",
   "private": true,
   "engines": {
-    "node": ">=20"
+    "node": ">=18"
   },
   "tests": [
     {
       "engines": {
-        "node": ">=20"
+        "node": ">=18"
       },
       "dependencies": {
         "@google/genai": "^1.2.0"