Skip to content

Conversation

@LukasKalbertodt
Copy link
Contributor

@LukasKalbertodt LukasKalbertodt commented Aug 13, 2022

I just released a new version of libtest-mimic. This is one of the bigger libaries using it, so as a sanity check whether the new version still works for real world users, I just did this update. It allowed to remove some of the code here as the API changed a bit.

Two things to note:

  • libtest-mimic requires Rust 1.58.
  • I do not know anything about this project and did not test anything except compiling and running the tests (via cargo test). Please review carefully and/or test.

@sunshowers
Copy link
Member

Thanks! Looks good, I'll make sure it passes CI and then land this.

@sunshowers
Copy link
Member

@LukasKalbertodt it looks like libtest-mimic lost the ability to do --nocapture. Could you fix this upstream? Thanks.

@sunshowers
Copy link
Member

Since libtest-mimic can't perform --nocapture anyway, it would be best to accept the argument but just ignore it.

@sunshowers
Copy link
Member

Submitted LukasKalbertodt/libtest-mimic#18 -- once that is released to crates.io, we can move datatest-stable over as well.

@LukasKalbertodt
Copy link
Contributor Author

Ah dang, I should have asked you to check out my changes before I cut the release. But well, can be fixed via patch release.

@LukasKalbertodt
Copy link
Contributor Author

I just released 0.5.2 with --nocapture. I also amended my PR here with the new commit now requiring 0.5.2.

@LukasKalbertodt LukasKalbertodt changed the title Update libtest-mimic to 0.5.1 Update libtest-mimic to 0.5.2 Aug 14, 2022
@LukasKalbertodt
Copy link
Contributor Author

I just fixed the clippy warnings. But the other CI jobs fail as they test with Rust 1.56. Is my assumption correct that you want to bump the MSRV of this project to 1.58? If so, should I adjust the CI jobs?

@sunshowers
Copy link
Member

Yeah, please change CI to reflect the new MSRV. Thanks!

@sunshowers sunshowers merged commit bdd7927 into nextest-rs:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants