-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: update icu to 78.1 #60523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
deps: update icu to 78.1 #60523
Conversation
|
Review requested:
|
|
/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60523 +/- ##
==========================================
- Coverage 88.56% 88.54% -0.02%
==========================================
Files 703 703
Lines 208254 208239 -15
Branches 40156 40153 -3
==========================================
- Hits 184430 184394 -36
- Misses 15828 15866 +38
+ Partials 7996 7979 -17 🚀 New features to boost your workflow:
|
baeca56 to
ebd8b44
Compare
FWIW it looks like a change when DST is not in effect (no longer outputs > process.env.TZ='Europe/Dublin'
'Europe/Dublin'
> new Date('2025/10/01').toLocaleString('en-US', { timeZoneName: 'long' })
'10/1/2025, 12:00:00 AM Irish Standard Time'
> new Date('2025/11/01').toLocaleString('en-US', { timeZoneName: 'long' })
'11/1/2025, 12:00:00 AM GMT+00:00'
> |
|
/cc @srl295 The new output looks more like what we should get with |
5afe4cd to
7432ece
Compare
|
I pushed an update to the test, but still not convinced that it's an expected change. |
caed27b to
ce2ac62
Compare
Can you file a CLDR issue ? |
68c8ee3 to
720ba2e
Compare
it's now an ICU bug, precipitated by a CLDR change. |
c5eb768 to
2d16ed0
Compare
2d16ed0 to
e132ee8
Compare
e132ee8 to
e321882
Compare
|
https://unicode-org.atlassian.net/browse/ICU-23278 Let's wait for 78.2 or 79.1. |
SGTM. FWIW unicode-org/icu#3784 updates Having said that, we do regenerate the dat file to pick up timezone updates (there's one coming (2025c) from unicode-org/icu-data#46). |
e321882 to
2230f12
Compare
This is an automated update of icu to 78.1.