Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of icu to 78.1.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. icu Issues and PRs related to the ICU dependency. test Issues and PRs related to the tests. labels Nov 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@targos
Copy link
Member

targos commented Nov 1, 2025

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (7fd3688) to head (c5eb768).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60523      +/-   ##
==========================================
- Coverage   88.56%   88.54%   -0.02%     
==========================================
  Files         703      703              
  Lines      208254   208239      -15     
  Branches    40156    40153       -3     
==========================================
- Hits       184430   184394      -36     
- Misses      15828    15866      +38     
+ Partials     7996     7979      -17     

see 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau
Copy link
Member

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

FWIW it looks like a change when DST is not in effect (no longer outputs Greenwich Mean time):

> process.env.TZ='Europe/Dublin'
'Europe/Dublin'
> new Date('2025/10/01').toLocaleString('en-US', { timeZoneName: 'long' })
'10/1/2025, 12:00:00 AM Irish Standard Time'
> new Date('2025/11/01').toLocaleString('en-US', { timeZoneName: 'long' })
'11/1/2025, 12:00:00 AM GMT+00:00'
>

@targos
Copy link
Member

targos commented Nov 8, 2025

/cc @srl295

The new output looks more like what we should get with timeZoneName: "longOffset"

@targos
Copy link
Member

targos commented Nov 10, 2025

I pushed an update to the test, but still not convinced that it's an expected change.

@srl295
Copy link
Member

srl295 commented Nov 21, 2025

I pushed an update to the test, but still not convinced that it's an expected change.

Can you file a CLDR issue ?

@targos
Copy link
Member

targos commented Nov 27, 2025

@srl295
Copy link
Member

srl295 commented Nov 29, 2025

CLDR bug: https://unicode-org.atlassian.net/browse/CLDR-19136

it's now an ICU bug, precipitated by a CLDR change.

@targos targos marked this pull request as draft December 14, 2025 09:53
@targos
Copy link
Member

targos commented Dec 14, 2025

@richardlau
Copy link
Member

https://unicode-org.atlassian.net/browse/ICU-23278

Let's wait for 78.2 or 79.1.

SGTM. FWIW unicode-org/icu#3784 updates icu4c/source/data/misc/metaZones.txt which we don't check into the Node.js source tree so we'd have to regenerate deps/icu-small/source/data/in/icudt78l.dat.bz2 (i.e. we cannot use the floating patch method in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#floating-patches-to-icu).

Having said that, we do regenerate the dat file to pick up timezone updates (there's one coming (2025c) from unicode-org/icu-data#46).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants