feat(api): support for configuring several filetypes in one go #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes in one go Resolves #14 But it basically doubles the code in filetype.lua, so I'm not sure if it should be merged.
glepnir
reviewed
Jul 18, 2023
I also changed the behaviour of GuardDisable so that it will not complain when ran several times for the same filetype
glepnir
reviewed
Jul 18, 2023
| @@ -37,7 +37,7 @@ end | |||
|
|
|||
|
|
|||
| local function box_for_group(fts) | |||
There was a problem hiding this comment.
I am very confuse on there. can we reuse exist function instead of create box_for_group lots of things are duplicated
There was a problem hiding this comment.
Well yes and no.
The object returned by ft({"foo", "bar"}) would have to use a different set of logic. But the fmt, lint and append methods are really just calling the respective methods on ft("foo") and ft("bar") (in this case). I don't know if the logic could be simplified further.
There was a problem hiding this comment.
Maybe the metatable related logic could be abstracted tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14
But it basically doubles the code in filetype.lua, so I'm not sure if it should be merged, if it does I will update the README.