refactor(lint): modularize json linters #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* zig format support * add goimports support * add gofumpt and jq
feat(lint): luacheck
feat(lint): support hadolint
|
I think can |
|
Ready for review. Code actually works very nicely. All linters have been refactored - only 20 lines max! Seeking advice in file Should the file be extracted to |
|
The unified conversion interface looks good. But git log can be a bit confusing |
glepnir
reviewed
Aug 16, 2023
|
I'm bad at git lol. Closing this and re-opening with cleaner git history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor linters using json to use "from_json"
still wip
prep for "guard-collection"