fix: silent warning message & wrong exit status check

[xiaoshihou514]

Just been testing with selene and found two issues.

• on_failed was silent again(process %s exited ... message did not show up), so I reverted a change.
• Finally I found that the exist status check was not behaving as expected as it exits with exit code 1 and an empty stderr(which should have been fine!) Guess I wasn't paying enough attention previously 😅

[xiaoshihou514]

Maybe related to #77 , idk

[glepnir]

there should not be or ?

[xiaoshihou514]

That makes it equivalent to the original code, where either a non-zero exit code or non empty stderr indicates a lint failure. The problem is linters return non-zero exit code (for instance selene returns 1 when it found errors in given file) when the lint succeeds. So here both need to be fulfilled before one could determine that the lint fails.

[barrett-ruth]

Is this change not the same as keeping the original code and replacing the and with an or?

[xiaoshihou514]

Is this change not the same as keeping the original code and replacing the and with an or?

It is, but I feel this way it's clearer what is being achieved

[barrett-ruth]

Thanks for this, was suspect on those changes I implemented - my bad.

[xiaoshihou514]

Thanks for this, was suspect on those changes I implemented - my bad.

I should have done more testing! My laptop wasn't available at that timing :( It's definitely best to be more cautious next time, so as not to break someone's workflow.