Template string performance improvements and more #8143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Dec 18, 2025
| // BenchmarkBuiltinTemplateString/primitives-16 8217890 144.9 ns/op 440 B/op 7 allocs/op | ||
| // BenchmarkBuiltinTemplateString/collections-16 2056494 583.7 ns/op 1144 B/op 28 allocs/op | ||
| // BenchmarkBuiltinTemplateString/multiple_outputs-16 9424003 128.8 ns/op 480 B/op 7 allocs/op | ||
| func BenchmarkBuiltinTemplateString(b *testing.B) { |
Member
Author
There was a problem hiding this comment.
Before this PR:
// BenchmarkBuiltinTemplateString/no_parts-16 8326574 128.5 ns/op 632 B/op 5 allocs/op
// BenchmarkBuiltinTemplateString/single_string_part-16 6282360 189.5 ns/op 952 B/op 8 allocs/op
// BenchmarkBuiltinTemplateString/single_undefined_part-16 6194984 192.3 ns/op 952 B/op 8 allocs/op
// BenchmarkBuiltinTemplateString/primitives-16 3178212 379.5 ns/op 1880 B/op 12 allocs/op
// BenchmarkBuiltinTemplateString/collections-16 1000000 1241 ns/op 4603 B/op 40 allocs/op
// BenchmarkBuiltinTemplateString/multiple_outputs-16 4449758 269.4 ns/op 1344 B/op 10 allocs/op
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
There's a conflict.... Please take a look 👇 |
A mixed bag of improvements I have had around for a while, and would like to see included in v1.12.0 if possible. I have about twice the amount of changes **not** included here as they could use some more testing. These changes should be low risk, I believe.. but obviously do let me know if you see any potential risks that I don't! - Add template string benchmarks - Faster template strings / print eval by not passing bctx in recursion - Allow passing nil value to `Query.WithQueryTracer` (no-op) - Reduce allocations in rego v1 compiler stages - Intern a few more common var name `Value`s - Remove redundant switch on `scope` in annotations code - Add a few more benchmarks in the `ast` package - Performance improvements in type checker, most notably removing a function literal for checking expression, which only ever had one implementation. We can extend this later if needed. - Prefer `NewGenericTransformer` over `&GenericTransformer` for easier tracking in pprof Signed-off-by: Anders Eknert <[email protected]>
34dfc32 to
b53f81b
Compare
johanfylling
added a commit
to johanfylling/opa
that referenced
this pull request
Dec 18, 2025
Signed-off-by: Johan Fylling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mixed bag of improvements I have had around for a while, and would like to see included in v1.12.0 if possible. I have about twice the amount of changes not included here as they could use some more testing. These changes should be low risk, I believe.. but obviously do let me know if you see any potential risks that I don't!
Query.WithQueryTracer(no-op)Valuesscopein annotations codeastpackageNewGenericTransformerover&GenericTransformerfor easier tracking in pprof