internal/plugins: update instead of overwrite samples kustomization #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stomizesamples`
to `config/samples/kustomization.yaml` so that this file can be updated
with new CR files without being completely overwritten.
internal/plugins/manifests: add samples kustomization scaffold
internal/plugins/{ansible,golang,helm}: update RunCreateAPI() call with
the scaffolded resource
estroz
commented
Aug 4, 2020
| file.TemplateMixin | ||
|
|
||
| // GroupVersionKind is the sample's gvk to add to this scaffold. | ||
| GroupVersionKind config.GVK |
Member
Author
There was a problem hiding this comment.
I'm using a config.GVK here since this plugin shouldn't "known" about the resource a phase 1 plugin created or how it was created (namespaced? native API?), just what's in the config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: This commit adds a scaffold marker
+kubebuilder:scaffold:manifestskustomizesamplestoconfig/samples/kustomization.yamlso that this file can be updated with new CR files without being completely overwritten. Users should now be able to add multiple samples of their CRDs to their samples kustomization.Closes #3370
/cc @joelanford @asmacdo @fabianvf @camilamacedo86
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs