TST/STYLE: remove multiprocess nose flags and slight PEP fixes #15333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I ended up having to autopep8 things to remove the extra lines when I took out the multiprocessing directive. But seems to pass and all be good. Slight PEP is even on non-qa files (some aspects of them). |
Member
|
This will not conflict with Tom's pytest PR? |
Contributor
|
I just did a test rebase on top of this, and didn't have to resolve any conflicts. Haven't looked at the new diff yet though. |
Member
|
@jreback The test files are not tested for PEP8 on travis? And would they pass now with those changes? |
Contributor
Author
|
i am not 100% sure we are testing ALL files (that's why some things were changed) everything passes now but let me see if i can add the other files |
Contributor
Author
|
actually I think the slight peps are to files what we ignore flake on. so pretty innocuous. |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
xref pandas-dev#13856 (comment) Author: Jeff Reback <[email protected]> Closes pandas-dev#15333 from jreback/mcs and squashes the following commits: 2edc842 [Jeff Reback] TST/STYLE: remove multiprocess nose flags and slight PEP fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13856 (comment)