Skip to content

Fix uncaught OutOfBounds in array_to_datetime #19612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 8 commits into from
Feb 11, 2018
Merged

Fix uncaught OutOfBounds in array_to_datetime #19612

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52d1040
catch more specific error, catch convert_datetime_to_tsobject error c…
jbrockmendel Feb 9, 2018
49cbe97
whitespace fixup
jbrockmendel Feb 9, 2018
68a11b3
fixup namerror
jbrockmendel Feb 9, 2018
4fdef03
fix assertion
jbrockmendel Feb 9, 2018
c45d282
remove unused import
jbrockmendel Feb 9, 2018
ad61c6a
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel Feb 10, 2018
4b1b9f8
move test
jbrockmendel Feb 10, 2018
9999e2d
Whatsnew note
jbrockmendel Feb 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whitespace fixup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Feb 9, 2018
commit 49cbe974e179b88d12106e10167881dbae710ef6
2 changes: 1 addition & 1 deletion pandas/tests/tslibs/test_tslib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class TestArrayToDatetime(object):
Copy link
Contributor

@jreback jreback Feb 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this should be in pandas/tests/indexes/datetimes/test_tools.py. I know you are ceating new locations is fine. but would rather move all of tools testing there (in a new PR).

def test_coerce_out_of_bounds_utc(self):
ts = pd.Timestamp('1900-01-01', tz='US/Pacific')
dt = ts.to_pydatetime() - timedelta(days=365*300) # ~1600AD
dt = ts.to_pydatetime() - timedelta(days=365 * 300) # ~1600AD
arr = np.array([dt])
result = array_to_datetime(arr, utc=True, errors='coerce')
assert (result == iNaT).all()