Skip to content

Fix minor error in dynamic load function #25256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 7 commits into from
Feb 28, 2019
Merged

Fix minor error in dynamic load function #25256

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b35573
Fix minor error in dynamic load function
nmusolino Feb 10, 2019
34152ef
Add basic tests of validate_docstrings.Docstring
nmusolino Feb 21, 2019
480a3de
Match message in validate_docstrings test
nmusolino Feb 22, 2019
64ec859
Use idiomatic pytest parameter unpacking
nmusolino Feb 28, 2019
7f7d577
Use standard pandas import in test_validate_docstrings
nmusolino Feb 28, 2019
f4704ea
Match AttributeError raised by getattr per review
nmusolino Feb 28, 2019
1b1ee48
Update test_validate_docstrings.py
WillAyd Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test_validate_docstrings.py 
Minor tweaks
  • Loading branch information
@WillAyd
WillAyd authored Feb 28, 2019
commit 1b1ee481e4bf0db4d462bac14413160f0c70aac7
4 changes: 1 addition & 3 deletions scripts/tests/test_validate_docstrings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,9 +1017,7 @@ def test_resolves_class_name(self, name, expected_obj):

@pytest.mark.parametrize('invalid_name', ['panda', 'panda.DataFrame'])
def test_raises_for_invalid_module_name(self, invalid_name):
# When an invalid module name is supplied, an ImportError should be
# raised, and the message should contain the user-supplied name.
msg = 'No module can be imported.*{}'.format(invalid_name)
msg = 'No module can be imported from "{}"'.format(invalid_name)
with pytest.raises(ImportError, match=msg):
validate_docstrings.Docstring(invalid_name)

Expand Down