Skip to content

REF: Separate window bounds calculation from aggregation functions #29428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Nov 21, 2019
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
7cb42b0
Have self._get_roll_func validate function import from window.pyx
Oct 27, 2019
dfe6f39
Standardize center arg
Oct 27, 2019
c608b44
always call get_window in _apply
Oct 28, 2019
45c89c7
move min_period calculation up the stack
Oct 28, 2019
c288137
Remove fetching of window function in _apply
Oct 28, 2019
1d90df6
Black
Oct 28, 2019
20d4490
Ensure all passed _apply functions are standardized
Oct 29, 2019
782209f
Migrate indexers to their own file
Oct 30, 2019
592db08
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 3, 2019
6b1935e
Integrating indexers
Nov 4, 2019
c7df962
Change all cython function signatures
Nov 4, 2019
9cc2b03
Add function to get variable vs fixed function
Nov 5, 2019
fd51fec
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 6, 2019
ef09f13
Remove is_variable cdef variable
Nov 6, 2019
1195461
Fix some cython compilation
Nov 6, 2019
71e08da
Ensure window_indexer.pyx gets compiled by cython
Nov 6, 2019
41f0775
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 9, 2019
5205174
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 10, 2019
a764caf
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 10, 2019
4c1915a
incremental progress on tests
Nov 11, 2019
a9809ea
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 12, 2019
045a285
Fix more tests
Nov 12, 2019
3c97e82
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 13, 2019
3844a3a
Pass name=func for groupby.rolling compat
Nov 13, 2019
019c58e
Fix 2 more tests
Nov 13, 2019
b334926
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 14, 2019
8401061
Fix more tests
Nov 14, 2019
4f628dd
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 15, 2019
1a5265d
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 17, 2019
e20682a
Fix more bugs
Nov 19, 2019
57c9621
Fix all the tests
Nov 19, 2019
23cc995
black
Nov 19, 2019
4be1bc4
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 19, 2019
2a13e9f
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 20, 2019
5f8751a
Lint pyx files
Nov 20, 2019
72703bd
Address Brock's comments
Nov 20, 2019
43af04f
Deprivatize calculate_min_periods
Nov 20, 2019
f1e7c7a
More linting of pyx files
Nov 20, 2019
80df109
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 20, 2019
8294705
Fix typing and lint issue
Nov 20, 2019
2cf048c
Merge remote-tracking branch 'upstream/master' into clean_rolling_int…
Nov 20, 2019
09ae258
Docstring updates
Nov 21, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove is_variable cdef variable
  • Loading branch information
Matt Roeschke committed Nov 6, 2019
commit ef09f13c4e3e2af200dcd5a4a428222195359b0f
7 changes: 1 addition & 6 deletions pandas/_libs/window.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,6 @@ def roll_skew_fixed(ndarray[float64_t] values, ndarray[int64_t] start, ndarray[i
float64_t x = 0, xx = 0, xxx = 0
int64_t nobs = 0, i, j, N = len(values)
int64_t s, e
bint is_variable
int64_t[:] start, end
ndarray[float64_t] output

Expand Down Expand Up @@ -639,7 +638,6 @@ def roll_skew_variable(ndarray[float64_t] values, ndarray[int64_t] start, ndarra
float64_t x = 0, xx = 0, xxx = 0
int64_t nobs = 0, i, j, N = len(values)
int64_t s, e
bint is_variable
ndarray[int64_t] start, end
ndarray[float64_t] output

Expand Down Expand Up @@ -830,7 +828,7 @@ def roll_median_c(ndarray[float64_t] values, ndarray[int64_t] start, ndarray[int
int64_t minp, int64_t win):
cdef:
float64_t val, res, prev
bint err = 0, is_variable
bint err = 0
int ret = 0
skiplist_t *sl
Py_ssize_t i, j
Expand Down Expand Up @@ -1226,7 +1224,6 @@ def roll_quantile(ndarray[float64_t, cast=True] values, ndarray[int64_t] start,
skiplist_t *skiplist
int64_t nobs = 0, i, j, s, e, N
Py_ssize_t idx
bint is_variable
int64_t[:] start, end
ndarray[float64_t] output
float64_t vlow, vhigh
Expand Down Expand Up @@ -1340,7 +1337,6 @@ def roll_generic_fixed(object obj,
float64_t *buf
float64_t *oldbuf
int64_t nobs = 0, i, j, s, e, N
bint is_variable
int64_t[:] start, end

n = len(obj)
Expand Down Expand Up @@ -1414,7 +1410,6 @@ def roll_generic_variable(object obj,
float64_t *buf
float64_t *oldbuf
int64_t nobs = 0, i, j, s, e, N
bint is_variable
ndarray[int64_t] start, end

n = len(obj)
Expand Down