ENH: add validate as a param to join (#46622) #46740
Conversation
|
Does it matter for the change to be merged if one code check fails? The failure seems to come from a file I never touched, while the previous two commits were able to pass all checks. |
This was a known failure affecting all builds. Just waiting on if other maintainers would like to review |
Sure. Thank you! |
| @@ -104,6 +107,126 @@ def test_suffix_on_list_join(): | |||
| tm.assert_frame_equal(arr_joined, norm_joined) | |||
|
|
|||
|
|
|||
| def test_join_on_single_col_check_dup(): | |||
| # GH 46622 | |||
There was a problem hiding this comment.
Could you either try parametrizing this or creating multiple tests? This is hard to debug if something goes wrong
There was a problem hiding this comment.
If this test fails, it's easy to trace the issue with the line and corresponding comments in this function. I don't think of an easy way of parametrizing that does not make this messier. Could you double check?
There was a problem hiding this comment.
Multiple tests are fine too.
If the first fails all other checks are not executed. Also it is not easy to see how the df looks if a check further below fails
There was a problem hiding this comment.
Just changed. Does it look better now? Thanks.
There was a problem hiding this comment.
Oh sorry. Forgot to add test_join.py after resolving conflict with the upstream/main. Please check again
|
looks good, it might be worth adding something to https://pandas.pydata.org/pandas-docs/dev/user_guide/merging.html?highlight=join#joining-on-index (there is a lot of sections, so this is a maybe). |
|
thanks @gaotian98 very nice! |
closes ENH: Join - Add a parameter to check for duplicates #46622
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added an entry in the latest
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.