Skip to content

DEPR: inplace kwarg in set_index #48115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022
Merged

DEPR: inplace kwarg in set_index #48115

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca359fd
DEPR: inplace kwarg in set_index
jbrockmendel Aug 16, 2022
031d701
GH ref
jbrockmendel Aug 16, 2022
7cd31cf
Merge branch 'main' into depr-set_index-inplace
jbrockmendel Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into depr-set_index-inplace
  • Loading branch information
@jbrockmendel
jbrockmendel committed Aug 17, 2022
commit 7cd31cf91cf1ef95d723e745f98e827835c30ca5
3 changes: 0 additions & 3 deletions pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,9 +1771,6 @@ def get_result(self, copy: bool = True) -> DataFrame:
join_index, left_join_indexer, right_join_indexer, copy=copy
)

typ = self.left._constructor
result = typ(result_data)

result = self._maybe_add_join_keys(result, left_indexer, right_indexer)

return result
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.