Skip to content

REGR: Performance decrease in factorize #48620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phofl merged 8 commits into from
Sep 22, 2022
Merged

REGR: Performance decrease in factorize #48620

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b072b82
PERF: Only check isna in certain cases in factorize
rhshadrach Sep 17, 2022
65f4c4b
Remove type-ignore
rhshadrach Sep 17, 2022
3a60993
Reformat
rhshadrach Sep 17, 2022
a9962b7
Merge branch 'main' of https://github.com/pandas-dev/pandas into grou…
rhshadrach Sep 18, 2022
135b1d3
Check for object dtype
rhshadrach Sep 18, 2022
79f399d
Merge branch 'main' of https://github.com/pandas-dev/pandas into grou…
rhshadrach Sep 20, 2022
58c6377
whatsnew note
rhshadrach Sep 20, 2022
131d36e
Merge branch 'main' into groupby_na_regr_v2
rhshadrach Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whatsnew note
  • Loading branch information
@rhshadrach
rhshadrach committed Sep 20, 2022
commit 58c63771d2acfccbbd3ca106e63cff13b5a99134
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ including other versions of pandas.

Fixed regressions
~~~~~~~~~~~~~~~~~
-
- Fixed performance regression in :func:`factorize` when ``na_sentinel`` is not ``None`` and ``sort=False`` (:issue:`48620`)
-

.. ---------------------------------------------------------------------------
Expand Down